Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1317)

Unified Diff: chrome/browser/extensions/activity_log/counting_policy.cc

Issue 106433007: Update some uses of Value in chrome/browser to use the base:: namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/activity_log/counting_policy.cc
diff --git a/chrome/browser/extensions/activity_log/counting_policy.cc b/chrome/browser/extensions/activity_log/counting_policy.cc
index fb9a0cb3541373342cfb8e113a31fe5339a46401..ae934666d901fac5ba9f793e9f3e49acb0b472f4 100644
--- a/chrome/browser/extensions/activity_log/counting_policy.cc
+++ b/chrome/browser/extensions/activity_log/counting_policy.cc
@@ -490,11 +490,11 @@ scoped_ptr<Action::ActionVector> CountingPolicy::DoReadFilteredData(
query.ColumnString(3));
if (query.ColumnType(4) != sql::COLUMN_TYPE_NULL) {
- scoped_ptr<Value> parsed_value(
+ scoped_ptr<base::Value> parsed_value(
base::JSONReader::Read(query.ColumnString(4)));
- if (parsed_value && parsed_value->IsType(Value::TYPE_LIST)) {
- action->set_args(
- make_scoped_ptr(static_cast<ListValue*>(parsed_value.release())));
+ if (parsed_value && parsed_value->IsType(base::Value::TYPE_LIST)) {
+ action->set_args(make_scoped_ptr(
+ static_cast<base::ListValue*>(parsed_value.release())));
}
}
@@ -503,11 +503,11 @@ scoped_ptr<Action::ActionVector> CountingPolicy::DoReadFilteredData(
action->ParseArgUrl(query.ColumnString(7));
if (query.ColumnType(8) != sql::COLUMN_TYPE_NULL) {
- scoped_ptr<Value> parsed_value(
+ scoped_ptr<base::Value> parsed_value(
base::JSONReader::Read(query.ColumnString(8)));
- if (parsed_value && parsed_value->IsType(Value::TYPE_DICTIONARY)) {
+ if (parsed_value && parsed_value->IsType(base::Value::TYPE_DICTIONARY)) {
action->set_other(make_scoped_ptr(
- static_cast<DictionaryValue*>(parsed_value.release())));
+ static_cast<base::DictionaryValue*>(parsed_value.release())));
}
}
action->set_count(query.ColumnInt(9));

Powered by Google App Engine
This is Rietveld 408576698