Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1789)

Unified Diff: chrome/browser/download/download_query_unittest.cc

Issue 106433007: Update some uses of Value in chrome/browser to use the base:: namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/download/download_dir_policy_handler.cc ('k') | chrome/browser/drive/fake_drive_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/download_query_unittest.cc
diff --git a/chrome/browser/download/download_query_unittest.cc b/chrome/browser/download/download_query_unittest.cc
index b1c4d58328751516bc46aeebe6021c9638bdc9a0..974c0b081c58be03693b63986024d0333ab8d91c 100644
--- a/chrome/browser/download/download_query_unittest.cc
+++ b/chrome/browser/download/download_query_unittest.cc
@@ -100,32 +100,32 @@ class DownloadQueryTest : public testing::Test {
template<> void DownloadQueryTest::AddFilter(
DownloadQuery::FilterType name, bool cpp_value) {
- scoped_ptr<base::Value> value(Value::CreateBooleanValue(cpp_value));
+ scoped_ptr<base::Value> value(base::Value::CreateBooleanValue(cpp_value));
CHECK(query_.AddFilter(name, *value.get()));
}
template<> void DownloadQueryTest::AddFilter(
DownloadQuery::FilterType name, int cpp_value) {
- scoped_ptr<base::Value> value(Value::CreateIntegerValue(cpp_value));
+ scoped_ptr<base::Value> value(base::Value::CreateIntegerValue(cpp_value));
CHECK(query_.AddFilter(name, *value.get()));
}
template<> void DownloadQueryTest::AddFilter(
DownloadQuery::FilterType name, const char* cpp_value) {
- scoped_ptr<base::Value> value(Value::CreateStringValue(cpp_value));
+ scoped_ptr<base::Value> value(base::Value::CreateStringValue(cpp_value));
CHECK(query_.AddFilter(name, *value.get()));
}
template<> void DownloadQueryTest::AddFilter(
DownloadQuery::FilterType name, std::string cpp_value) {
- scoped_ptr<base::Value> value(Value::CreateStringValue(cpp_value));
+ scoped_ptr<base::Value> value(base::Value::CreateStringValue(cpp_value));
CHECK(query_.AddFilter(name, *value.get()));
}
template<> void DownloadQueryTest::AddFilter(
DownloadQuery::FilterType name, const char16* cpp_value) {
scoped_ptr<base::Value> value(
- Value::CreateStringValue(base::string16(cpp_value)));
+ base::Value::CreateStringValue(base::string16(cpp_value)));
CHECK(query_.AddFilter(name, *value.get()));
}
@@ -134,7 +134,7 @@ template<> void DownloadQueryTest::AddFilter(
scoped_ptr<base::ListValue> list(new base::ListValue());
for (std::vector<base::string16>::const_iterator it = cpp_value.begin();
it != cpp_value.end(); ++it) {
- list->Append(Value::CreateStringValue(*it));
+ list->Append(base::Value::CreateStringValue(*it));
}
CHECK(query_.AddFilter(name, *list.get()));
}
@@ -144,7 +144,7 @@ template<> void DownloadQueryTest::AddFilter(
scoped_ptr<base::ListValue> list(new base::ListValue());
for (std::vector<std::string>::const_iterator it = cpp_value.begin();
it != cpp_value.end(); ++it) {
- list->Append(Value::CreateStringValue(*it));
+ list->Append(base::Value::CreateStringValue(*it));
}
CHECK(query_.AddFilter(name, *list.get()));
}
@@ -152,7 +152,7 @@ template<> void DownloadQueryTest::AddFilter(
#if defined(OS_WIN)
template<> void DownloadQueryTest::AddFilter(
DownloadQuery::FilterType name, std::wstring cpp_value) {
- scoped_ptr<base::Value> value(Value::CreateStringValue(cpp_value));
+ scoped_ptr<base::Value> value(base::Value::CreateStringValue(cpp_value));
CHECK(query_.AddFilter(name, *value.get()));
}
#endif
@@ -163,7 +163,7 @@ TEST_F(DownloadQueryTest, DownloadQueryTest_ZeroItems) {
}
TEST_F(DownloadQueryTest, DownloadQueryTest_InvalidFilter) {
- scoped_ptr<base::Value> value(Value::CreateIntegerValue(0));
+ scoped_ptr<base::Value> value(base::Value::CreateIntegerValue(0));
EXPECT_FALSE(query()->AddFilter(
static_cast<DownloadQuery::FilterType>(kint32max),
*value.get()));
« no previous file with comments | « chrome/browser/download/download_dir_policy_handler.cc ('k') | chrome/browser/drive/fake_drive_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698