chrome/browser/content_settings/content_settings_provider_unittest.cc - Issue 106433007: Update some uses of Value in chrome/browser to use the base:: namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/content_settings/content_settings_provider_unittest.cc

Issue 106433007: Update some uses of Value in chrome/browser to use the base:: namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/content_settings/content_settings_pref_provider_unittest.cc ('k') | chrome/browser/content_settings/host_content_settings_map.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/content_settings/content_settings_provider_unittest.cc

diff --git a/chrome/browser/content_settings/content_settings_provider_unittest.cc b/chrome/browser/content_settings/content_settings_provider_unittest.cc

index d3d092c597a846dbaacaae0ada21a477e5982adf..efd82e59b6165075f8bff6efea4240933801b660 100644

--- a/chrome/browser/content_settings/content_settings_provider_unittest.cc

+++ b/chrome/browser/content_settings/content_settings_provider_unittest.cc

@@ -22,14 +22,14 @@ TEST(ContentSettingsProviderTest, Mock) {

pattern,

CONTENT_SETTINGS_TYPE_PLUGINS,

"java_plugin",

- Value::CreateIntegerValue(CONTENT_SETTING_BLOCK));

+ base::Value::CreateIntegerValue(CONTENT_SETTING_BLOCK));

EXPECT_EQ(CONTENT_SETTING_BLOCK,

GetContentSetting(&mock_provider, url, url,

CONTENT_SETTINGS_TYPE_PLUGINS, "java_plugin",

false));

- scoped_ptr<Value> value_ptr(

+ scoped_ptr<base::Value> value_ptr(

GetContentSettingValue(&mock_provider, url, url,

CONTENT_SETTINGS_TYPE_PLUGINS,

"java_plugin", false));

@@ -65,7 +65,7 @@ TEST(ContentSettingsProviderTest, Mock) {

pattern,

CONTENT_SETTINGS_TYPE_PLUGINS,

"java_plugin",

- Value::CreateIntegerValue(CONTENT_SETTING_ALLOW));

+ base::Value::CreateIntegerValue(CONTENT_SETTING_ALLOW));

EXPECT_TRUE(owned);

EXPECT_EQ(CONTENT_SETTING_ALLOW,

GetContentSetting(&mock_provider, url, url,

@@ -74,7 +74,7 @@ TEST(ContentSettingsProviderTest, Mock) {

mock_provider.set_read_only(true);

scoped_ptr<base::Value> value(

- Value::CreateIntegerValue(CONTENT_SETTING_BLOCK));

+ base::Value::CreateIntegerValue(CONTENT_SETTING_BLOCK));

owned = mock_provider.SetWebsiteSetting(

pattern,

@@ -95,7 +95,7 @@ TEST(ContentSettingsProviderTest, Mock) {

pattern,

CONTENT_SETTINGS_TYPE_PLUGINS,

"java_plugin",

- Value::CreateIntegerValue(CONTENT_SETTING_BLOCK));

+ base::Value::CreateIntegerValue(CONTENT_SETTING_BLOCK));

EXPECT_TRUE(owned);

EXPECT_EQ(CONTENT_SETTING_BLOCK,

GetContentSetting(&mock_provider, url, url,