Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7131)

Unified Diff: chrome/browser/chromeos/proxy_cros_settings_parser.cc

Issue 106433007: Update some uses of Value in chrome/browser to use the base:: namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/proxy_cros_settings_parser.cc
diff --git a/chrome/browser/chromeos/proxy_cros_settings_parser.cc b/chrome/browser/chromeos/proxy_cros_settings_parser.cc
index 2ccb83d1777aa58f0ad5d61d4e95271d83a75ce9..581aeb718facf56fff897460ab5e9351fc483b18 100644
--- a/chrome/browser/chromeos/proxy_cros_settings_parser.cc
+++ b/chrome/browser/chromeos/proxy_cros_settings_parser.cc
@@ -268,7 +268,8 @@ void SetProxyPrefValue(const std::string& path,
} else if (path == kProxyIgnoreList) {
net::ProxyBypassRules bypass_rules;
if (in_value->GetType() == base::Value::TYPE_LIST) {
- const ListValue* list_value = static_cast<const ListValue*>(in_value);
+ const base::ListValue* list_value =
+ static_cast<const base::ListValue*>(in_value);
for (size_t x = 0; x < list_value->GetSize(); x++) {
std::string val;
if (list_value->GetString(x, &val))
@@ -350,7 +351,7 @@ bool GetProxyPrefValue(const UIProxyConfigService& config_service,
} else if (path == kProxySocksPort) {
data = CreateServerPortValue(config.socks_proxy);
} else if (path == kProxyIgnoreList) {
- ListValue* list = new ListValue();
+ base::ListValue* list = new base::ListValue();
net::ProxyBypassRules::RuleList bypass_rules = config.bypass_rules.rules();
for (size_t x = 0; x < bypass_rules.size(); x++)
list->Append(new base::StringValue(bypass_rules[x]->ToString()));
@@ -361,7 +362,7 @@ bool GetProxyPrefValue(const UIProxyConfigService& config_service,
}
// Decorate pref value as CoreOptionsHandler::CreateValueForPref() does.
- DictionaryValue* dict = new DictionaryValue;
+ base::DictionaryValue* dict = new base::DictionaryValue;
if (!data)
data = new base::StringValue("");
dict->Set("value", data);

Powered by Google App Engine
This is Rietveld 408576698