chrome/browser/background/background_application_list_model_unittest.cc - Issue 106433007: Update some uses of Value in chrome/browser to use the base:: namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/background/background_application_list_model_unittest.cc

Issue 106433007: Update some uses of Value in chrome/browser to use the base:: namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/automation/testing_automation_provider_chromeos.cc ('k') | chrome/browser/background/background_contents_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/background/background_application_list_model_unittest.cc

diff --git a/chrome/browser/background/background_application_list_model_unittest.cc b/chrome/browser/background/background_application_list_model_unittest.cc

index ed0bc04c48227fe564f0b80914667dbedcd497f0..d52ed8a2a9239a110298d6fbbf9d3729861baa53 100644

--- a/chrome/browser/background/background_application_list_model_unittest.cc

+++ b/chrome/browser/background/background_application_list_model_unittest.cc

@@ -73,17 +73,17 @@ static scoped_refptr<Extension> CreateExtensionBase(

const std::string& name,

bool background_permission,

PushMessagingOption push_messaging) {

- DictionaryValue manifest;

+ base::DictionaryValue manifest;

manifest.SetString(extensions::manifest_keys::kVersion, "1.0.0.0");

manifest.SetString(extensions::manifest_keys::kName, name);

- ListValue* permissions = new ListValue();

+ base::ListValue* permissions = new base::ListValue();

manifest.Set(extensions::manifest_keys::kPermissions, permissions);

if (background_permission) {

- permissions->Append(Value::CreateStringValue("background"));

+ permissions->Append(base::Value::CreateStringValue("background"));

}

if (push_messaging == PUSH_MESSAGING_PERMISSION ||

push_messaging == PUSH_MESSAGING_BUT_NOT_BACKGROUND) {

- permissions->Append(Value::CreateStringValue("pushMessaging"));

+ permissions->Append(base::Value::CreateStringValue("pushMessaging"));

}

std::string error;