Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: chrome/browser/automation/automation_util.cc

Issue 106433007: Update some uses of Value in chrome/browser to use the base:: namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/automation/automation_util.cc
diff --git a/chrome/browser/automation/automation_util.cc b/chrome/browser/automation/automation_util.cc
index 4fe928c01410c89d9d3ad6b5680fceb18c1442fc..3627ba8c8fc98c9ea6b30002be733acc43a64cdd 100644
--- a/chrome/browser/automation/automation_util.cc
+++ b/chrome/browser/automation/automation_util.cc
@@ -280,7 +280,7 @@ void DeleteCookie(const GURL& url,
}
void GetCookiesJSON(AutomationProvider* provider,
- DictionaryValue* args,
+ base::DictionaryValue* args,
IPC::Message* reply_message) {
AutomationJSONReply reply(provider, reply_message);
std::string url;
@@ -304,10 +304,10 @@ void GetCookiesJSON(AutomationProvider* provider,
}
event.Wait();
- ListValue* list = new ListValue();
+ base::ListValue* list = new base::ListValue();
for (size_t i = 0; i < cookie_list.size(); ++i) {
const net::CanonicalCookie& cookie = cookie_list[i];
- DictionaryValue* cookie_dict = new DictionaryValue();
+ base::DictionaryValue* cookie_dict = new base::DictionaryValue();
cookie_dict->SetString("name", cookie.Name());
cookie_dict->SetString("value", cookie.Value());
cookie_dict->SetString("path", cookie.Path());
@@ -322,13 +322,13 @@ void GetCookiesJSON(AutomationProvider* provider,
}
list->Append(cookie_dict);
}
- DictionaryValue dict;
+ base::DictionaryValue dict;
dict.Set("cookies", list);
reply.SendSuccess(&dict);
}
void DeleteCookieJSON(AutomationProvider* provider,
- DictionaryValue* args,
+ base::DictionaryValue* args,
IPC::Message* reply_message) {
AutomationJSONReply reply(provider, reply_message);
std::string url, name;
@@ -358,7 +358,7 @@ void DeleteCookieJSON(AutomationProvider* provider,
}
void SetCookieJSON(AutomationProvider* provider,
- DictionaryValue* args,
+ base::DictionaryValue* args,
IPC::Message* reply_message) {
AutomationJSONReply reply(provider, reply_message);
std::string url;
@@ -366,7 +366,7 @@ void SetCookieJSON(AutomationProvider* provider,
reply.SendError("'url' missing or invalid");
return;
}
- DictionaryValue* cookie_dict;
+ base::DictionaryValue* cookie_dict;
if (!args->GetDictionary("cookie", &cookie_dict)) {
reply.SendError("'cookie' missing or invalid");
return;

Powered by Google App Engine
This is Rietveld 408576698