chrome/browser/automation/automation_event_observers.cc - Issue 106433007: Update some uses of Value in chrome/browser to use the base:: namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/automation/automation_event_observers.cc

Issue 106433007: Update some uses of Value in chrome/browser to use the base:: namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/automation/automation_event_observers.h ('k') | chrome/browser/automation/automation_event_observers_chromeos.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/automation/automation_event_observers.cc

diff --git a/chrome/browser/automation/automation_event_observers.cc b/chrome/browser/automation/automation_event_observers.cc

index ef65bcd800a848b67898b4abd9b5364573c77d1d..e8006d32dae72321a26a089ca59b45de29302ab3 100644

--- a/chrome/browser/automation/automation_event_observers.cc

+++ b/chrome/browser/automation/automation_event_observers.cc

@@ -27,10 +27,10 @@ AutomationEventObserver::AutomationEventObserver(

AutomationEventObserver::~AutomationEventObserver() {}

-void AutomationEventObserver::NotifyEvent(DictionaryValue* value) {

+void AutomationEventObserver::NotifyEvent(base::DictionaryValue* value) {

if (event_queue_) {

if (!value)

- value = new DictionaryValue;

+ value = new base::DictionaryValue;

value->SetInteger("observer_id", GetId());

event_queue_->NotifyEvent(

new AutomationEventQueue::AutomationEvent(

@@ -94,7 +94,7 @@ void DomEventObserver::Observe(

automation_id_ == -1) &&

(event_name_.length() == 0 ||

event_name_.compare(dom_op_details->json) == 0)) {

- DictionaryValue* dict = new DictionaryValue;

+ base::DictionaryValue* dict = new base::DictionaryValue;

dict->SetString("type", "raised_event");

dict->SetString("name", dom_op_details->json);

NotifyEvent(dict);