chrome/browser/download/download_dir_policy_handler.cc - Issue 106433007: Update some uses of Value in chrome/browser to use the base:: namespace.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/download/download_dir_policy_handler.cc

Issue 106433007: Update some uses of Value in chrome/browser to use the base:: namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/diagnostics/recon_diagnostics.cc ('k') | chrome/browser/download/download_query_unittest.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/download/download_dir_policy_handler.h"	5 #include "chrome/browser/download/download_dir_policy_handler.h"

6	6

7 #include "base/files/file_path.h"	7 #include "base/files/file_path.h"

8 #include "base/memory/scoped_ptr.h"	8 #include "base/memory/scoped_ptr.h"

9 #include "base/prefs/pref_value_map.h"	9 #include "base/prefs/pref_value_map.h"

10 #include "base/values.h"	10 #include "base/values.h"

(...skipping 19 matching lines...) Expand all Loading...
30	30

31 base::FilePath::StringType expanded_value =	31 base::FilePath::StringType expanded_value =

32 policy::path_parser::ExpandPathVariables(string_value);	32 policy::path_parser::ExpandPathVariables(string_value);

33 // Make sure the path isn't empty, since that will point to an undefined	33 // Make sure the path isn't empty, since that will point to an undefined

34 // location; the default location is used instead in that case.	34 // location; the default location is used instead in that case.

35 // This is checked after path expansion because a non-empty policy value can	35 // This is checked after path expansion because a non-empty policy value can

36 // lead to an empty path value after expansion (e.g. "\"\"").	36 // lead to an empty path value after expansion (e.g. "\"\"").

37 if (expanded_value.empty())	37 if (expanded_value.empty())

38 expanded_value = DownloadPrefs::GetDefaultDownloadDirectory().value();	38 expanded_value = DownloadPrefs::GetDefaultDownloadDirectory().value();

39 prefs->SetValue(prefs::kDownloadDefaultDirectory,	39 prefs->SetValue(prefs::kDownloadDefaultDirectory,

40 Value::CreateStringValue(expanded_value));	40 base::Value::CreateStringValue(expanded_value));

41 prefs->SetValue(prefs::kPromptForDownload,	41 prefs->SetValue(prefs::kPromptForDownload,

42 Value::CreateBooleanValue(false));	42 base::Value::CreateBooleanValue(false));

43 }	43 }

OLD	NEW