Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1064283002: Merge to XFA: FFL_MIN and FFL_MAX are pointless and stupid. (Closed)

Created:
5 years, 8 months ago by Tom Sepez
Modified:
5 years, 8 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

FFL_MIN and FFL_MAX are pointless and stupid. Kill some nearby dead code while I'm at it. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/564be8ebf756c641be8ccacae6cb8f4fed8c4b58

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -28 lines) Patch
M fpdfsdk/include/formfiller/FFL_Utils.h View 1 chunk +0 lines, -3 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_Utils.cpp View 3 chunks +6 lines, -25 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
Lei, small cleanup.
5 years, 8 months ago (2015-04-07 23:39:07 UTC) #2
Lei Zhang
lgtm
5 years, 8 months ago (2015-04-07 23:52:55 UTC) #3
Tom Sepez
5 years, 8 months ago (2015-04-08 15:29:50 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
564be8ebf756c641be8ccacae6cb8f4fed8c4b58 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698