pkg/path: Add type annotations to top-level and static fields.

Add type annotations to top-level and static fields.

R=nweiz@google.com

Committed: https://github.com/dart-lang/path/commit/2f3dcdec32011f1bc41194ae3640d6d9292a7096

[kevmoo, 2015-04-07 23:19:53]

kevmoo@google.com changed reviewers:
+ nweiz@google.com

[kevmoo, 2015-04-07 23:19:53]

Having a dynamic return type implies that the type of these fields cannot be
counted on version-to-version.

Let's be explicit about the return type.

[nweiz, 2015-04-09 18:41:24]

https://codereview.chromium.org/1064273002/diff/1/lib/path.dart
File lib/path.dart (right):

https://codereview.chromium.org/1064273002/diff/1/lib/path.dart#newcode63
lib/path.dart:63: final Context url = new Context(style: Style.url);
I don't like this change. It adds verbosity without increasing readability. It's
already immediately clear to anyone looking at the code that these are Context
objects, since the word "Context" is right there.

https://codereview.chromium.org/1064273002/diff/1/pubspec.yaml
File pubspec.yaml (right):

https://codereview.chromium.org/1064273002/diff/1/pubspec.yaml#newcode2
pubspec.yaml:2: version: 1.3.4+1
Don't use build identifiers ("+1") for post-1.0.0 packages. This should be
1.3.5.

[kevmoo, 2015-04-09 19:07:55]

https://codereview.chromium.org/1064273002/diff/1/lib/path.dart
File lib/path.dart (right):

https://codereview.chromium.org/1064273002/diff/1/lib/path.dart#newcode63
lib/path.dart:63: final Context url = new Context(style: Style.url);
On 2015/04/09 18:41:23, nweiz wrote:
> I don't like this change. It adds verbosity without increasing readability.
It's
> already immediately clear to anyone looking at the code that these are Context
> objects, since the word "Context" is right there.

It's not about code reading, it's about how tools (IDEs, docgen) surface the
code.

Right now the type is 'dynamic' which is valid for many things where the user
shouldn't rely on the return type.

We should be explicit that the return type IS Context.

Even in C#, which has support for compile-type inference requires public members
to be typed.

https://codereview.chromium.org/1064273002/diff/1/pubspec.yaml
File pubspec.yaml (right):

https://codereview.chromium.org/1064273002/diff/1/pubspec.yaml#newcode2
pubspec.yaml:2: version: 1.3.4+1
On 2015/04/09 18:41:23, nweiz wrote:
> Don't use build identifiers ("+1") for post-1.0.0 packages. This should be
> 1.3.5.

Done.

[nweiz, 2015-04-09 20:09:20]

lgtm

[kevmoo, 2015-04-09 20:10:12]

Committed patchset #2 (id:20001) manually as
2f3dcdec32011f1bc41194ae3640d6d9292a7096 (presubmit successful).