Source/core/css/CSSParser.cpp - Issue 106423003: [oilpan] Rename visit to mark.

Unified Diff: Source/core/css/CSSParser.cpp

Issue 106423003: [oilpan] Rename visit to mark. (Closed) Base URL: svn://svn.chromium.org/blink/branches/oilpan

Patch Set: Address comments. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Index: Source/core/css/CSSParser.cpp

diff --git a/Source/core/css/CSSParser.cpp b/Source/core/css/CSSParser.cpp

index 31b14ece8d2ba01486de150134f61629b434d85b..3f065dd6b8f51cf8ee93fa111dc454aefbd9388f 100644

--- a/Source/core/css/CSSParser.cpp

+++ b/Source/core/css/CSSParser.cpp

@@ -8548,7 +8548,7 @@ StyleRuleBase* CSSParser::createFilterRule(const CSSParserString& filterName)

StyleRuleFilter* rule = StyleRuleFilter::create(filterName);

rule->setProperties(createStylePropertySet());

clearProperties();

- // FIXME(oilpan): Use of the raw pointer is safe because it is visited

+ // FIXME(oilpan): Use of the raw pointer is safe because it is traced

// via the m_parsedRules collection of Members. We should

// consider if we can deal with this in another way.

StyleRuleFilter* result = rule;

@@ -10865,7 +10865,7 @@ PassOwnPtr<Vector<OwnPtr<MediaQueryExp> > > CSSParser::sinkFloatingMediaQueryExp

MediaQuery* CSSParser::createFloatingMediaQuery(MediaQuery::Restrictor restrictor, const String& mediaType, PassOwnPtr<Vector<OwnPtr<MediaQueryExp> > > expressions)

{

m_floatingMediaQuery = MediaQuery::create(restrictor, mediaType, expressions);

- // FIXME(oilpan): Use of the raw pointer is safe because it is visited

+ // FIXME(oilpan): Use of the raw pointer is safe because it is traced

// via the persistent member m_floatingMediaQuery. We should

// consider if we can deal with this in another way.

return m_floatingMediaQuery;

@@ -10899,7 +10899,7 @@ MediaQuerySet* CSSParser::createMediaQuerySet()

{

MediaQuerySet* queries = MediaQuerySet::create();

m_parsedMediaQuerySets->append(queries);

- // FIXME(oilpan): Use of the raw pointer is safe because it is visited

+ // FIXME(oilpan): Use of the raw pointer is safe because it is traced

// via the m_parsedMediaQuerySets collection of Members. We should

// consider if we can deal with this in another way.

return queries;

@@ -10913,7 +10913,7 @@ StyleRuleBase* CSSParser::createImportRule(const CSSParserString& url, MediaQuer

}

MediaQuerySet* mediaHandle(media);

StyleRuleImport* rule = StyleRuleImport::create(url, mediaHandle);

- // FIXME(oilpan): Use of the raw pointer is safe because it is visited

+ // FIXME(oilpan): Use of the raw pointer is safe because it is traced

// via the m_parsedRules collection of Members. We should

// consider if we can deal with this in another way.

StyleRuleImport* result = rule;

@@ -10935,7 +10935,7 @@ StyleRuleBase* CSSParser::createMediaRule(MediaQuerySet* media, RuleList* rules)

RuleList emptyRules;

rule = StyleRuleMedia::create(mediaHandle, emptyRules);

}

- // FIXME(oilpan): Use of the raw pointer is safe because it is visited

+ // FIXME(oilpan): Use of the raw pointer is safe because it is traced

// via the m_parsedRules collection of Members. We should

// consider if we can deal with this in another way.

StyleRuleMedia* result = rule;

@@ -10966,7 +10966,7 @@ StyleRuleBase* CSSParser::createSupportsRule(bool conditionIsSupported, RuleList

rule = StyleRuleSupports::create(conditionText, conditionIsSupported, emptyRules);

}

- // FIXME(oilpan): Use of the raw pointer is safe because it is visited

+ // FIXME(oilpan): Use of the raw pointer is safe because it is traced

// via the m_parsedRules collection of Members. We should

// consider if we can deal with this in another way.

StyleRuleSupports* result = rule;

@@ -11054,7 +11054,7 @@ StyleRuleKeyframes* CSSParser::createKeyframesRule(const String& name, StyleKeyf

for (size_t i = 0; i < keyframes->size(); ++i)

rule->parserAppendKeyframe(keyframes->at(i));

rule->setName(name);

- // FIXME(oilpan): Use of the raw pointer is safe because it is visited

+ // FIXME(oilpan): Use of the raw pointer is safe because it is traced

// via the m_parsedRules collection of Members. We should

// consider if we can deal with this in another way.

StyleRuleKeyframes* rulePtr = rule;

@@ -11073,7 +11073,7 @@ StyleRuleBase* CSSParser::createStyleRule(Vector<OwnPtr<CSSParserSelector> >* se

if (m_hasFontFaceOnlyValues)

deleteFontFaceOnlyValues();

rule->setProperties(createStylePropertySet());

- // FIXME(oilpan): Use of the raw pointer is safe because it is visited

+ // FIXME(oilpan): Use of the raw pointer is safe because it is traced

// via the m_parsedRules collection of Members. We should

// consider if we can deal with this in another way.

result = rule;

@@ -11105,7 +11105,7 @@ StyleRuleBase* CSSParser::createFontFaceRule()

StyleRuleFontFace* rule = StyleRuleFontFace::create();

rule->setProperties(createStylePropertySet());

clearProperties();

- // FIXME(oilpan): Use of the raw pointer is safe because it is visited

+ // FIXME(oilpan): Use of the raw pointer is safe because it is traced

// via the m_parsedRules collection of Members. We should

// consider if we can deal with this in another way.

StyleRuleFontFace* result = rule;

@@ -11124,7 +11124,7 @@ StyleRuleBase* CSSParser::createHostRule(RuleList* rules)

RuleList emptyRules;

rule = StyleRuleHost::create(emptyRules);

}

- // FIXME(oilpan): Use of the raw pointer is safe because it is visited

+ // FIXME(oilpan): Use of the raw pointer is safe because it is traced

// via the m_parsedRules collection of Members. We should

// consider if we can deal with this in another way.

StyleRuleHost* result = rule;

@@ -11247,7 +11247,7 @@ StyleRuleBase* CSSParser::createPageRule(PassOwnPtr<CSSParserSelector> pageSelec

selectorVector.append(pageSelector);

rule->parserAdoptSelectorVector(selectorVector);

rule->setProperties(createStylePropertySet());

- // FIXME(oilpan): Use of the raw pointer is safe because it is visited

+ // FIXME(oilpan): Use of the raw pointer is safe because it is traced

// via the m_parsedRules collection of Members. We should

// consider if we can deal with this in another way.

pageRule = rule;

@@ -11276,7 +11276,7 @@ StyleRuleBase* CSSParser::createRegionRule(Vector<OwnPtr<CSSParserSelector> >* r

StyleRuleRegion* regionRule = StyleRuleRegion::create(regionSelector, *rules);

- // FIXME(oilpan): Use of the raw pointer is safe because it is visited

+ // FIXME(oilpan): Use of the raw pointer is safe because it is traced

// via the m_parsedRules collection of Members. We should

// consider if we can deal with this in another way.

StyleRuleRegion* result = regionRule;

@@ -11357,7 +11357,7 @@ StyleKeyframe* CSSParser::createKeyframe(CSSParserValueList* keys)

clearProperties();

m_parsedKeyframes->append(keyframe);

- // FIXME(oilpan): Use of the raw pointer is safe because it is visited

+ // FIXME(oilpan): Use of the raw pointer is safe because it is traced

// via the m_parsedKeyframes collection of Members. We should

// consider if we can deal with this in another way.

return keyframe;

« no previous file with comments | « Source/core/css/CSSFontSelector.cpp ('k') | Source/core/css/CSSPrimitiveValue.cpp » ('j') | no next file with comments »