Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Unified Diff: Source/core/css/CSSFontSelector.cpp

Issue 106423003: [oilpan] Rename visit to mark. (Closed) Base URL: svn://svn.chromium.org/blink/branches/oilpan
Patch Set: Address comments. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/css/CSSParser.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/CSSFontSelector.cpp
diff --git a/Source/core/css/CSSFontSelector.cpp b/Source/core/css/CSSFontSelector.cpp
index 7340f0e57ff13f3825f458066b7f1a2344faee21..902316438ac68f01476521af22ae33061d64c628 100644
--- a/Source/core/css/CSSFontSelector.cpp
+++ b/Source/core/css/CSSFontSelector.cpp
@@ -628,10 +628,7 @@ void CSSFontSelector::beginLoadTimerFired(Timer<WebCore::CSSFontSelector>*)
void CSSFontSelector::trace(Visitor* visitor)
{
- // FIXME(oilpan): visiting m_document creates a cycle through a persistent handle because document owns StyleResolver
- // which hold CSSFontSelector via persistent handle. Once StyleResolver is moved to the heap we should start visiting
- // m_document again.
- // visitor->trace(m_document);
+ visitor->trace(m_document);
visitor->trace(m_fontFaces);
visitor->trace(m_locallyInstalledFontFaces);
visitor->trace(m_fonts);
« no previous file with comments | « no previous file | Source/core/css/CSSParser.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698