[oilpan] Rename visit to mark.

[oilpan] Rename visit to mark.

BUG=
R=erik.corry@gmail.com, haraken@chromium.org, wibling@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163311

[Mads Ager (chromium), 2013-12-05 12:10:00]

A couple of minor changes pointed out in comments.

I removed the AcceptChecker which does not work at this point and is always in
the way when making sweeping changes.

https://codereview.chromium.org/106423003/diff/40001/Source/core/css/CSSFontS...
File Source/core/css/CSSFontSelector.cpp (left):

https://codereview.chromium.org/106423003/diff/40001/Source/core/css/CSSFontS...
Source/core/css/CSSFontSelector.cpp:632: // FIXME(oilpan): visiting m_document
creates a cycle through a persistent handle because document owns StyleResolver
The cycle described here no longer exists. We did move StyleResolver to the
heap.

https://codereview.chromium.org/106423003/diff/40001/Source/core/html/HTMLCol...
File Source/core/html/HTMLCollection.cpp (left):

https://codereview.chromium.org/106423003/diff/40001/Source/core/html/HTMLCol...
Source/core/html/HTMLCollection.cpp:733: NodeCacheMap::const_iterator end =
m_idCache.end();
Minor cleanup: the visitor knows how to trace collections.

[wibling-chromium, 2013-12-05 12:37:16]

LGTM

https://codereview.chromium.org/106423003/diff/40001/Source/heap/Handle.h
File Source/heap/Handle.h (right):

https://codereview.chromium.org/106423003/diff/40001/Source/heap/Handle.h#new...
Source/heap/Handle.h:63: template<typename T> struct
OffHeapCollectionTraceTrait;
NIT: Shouldn't this be OffHeapCollectionMarkTrait?

[Mads Ager (chromium), 2013-12-05 12:41:17]

https://codereview.chromium.org/106423003/diff/40001/Source/heap/Handle.h
File Source/heap/Handle.h (right):

https://codereview.chromium.org/106423003/diff/40001/Source/heap/Handle.h#new...
Source/heap/Handle.h:63: template<typename T> struct
OffHeapCollectionTraceTrait;
On 2013/12/05 12:37:17, wibling-chromium wrote:
> NIT: Shouldn't this be OffHeapCollectionMarkTrait?

I found it more fitting to call it a TraceTrait. This trait controls how
pointers inside a collection are iterated. When we look through the pointers in
an object we usually call that trace.

[haraken, 2013-12-05 14:49:15]

LGTM. This looks much better.

[haraken, 2013-12-06 09:11:17]

Nit: I don't want to bike-shed any more, but you could rename Visitor to Tracer
if you like. (If you want to make the exposed names consistent, "Tracer" will be
better. If you feel strange to make "Tracer" do both "trace" and "mark",
"Visitor" will be better. I just thought this because you want to call the trait
"TraceTrait" instead of "VisitTrait".)

[Erik Corry, 2013-12-06 10:30:32]

lgtm

https://codereview.chromium.org/106423003/diff/40001/Source/heap/Heap.h
File Source/heap/Heap.h (right):

https://codereview.chromium.org/106423003/diff/40001/Source/heap/Heap.h#newco...
Source/heap/Heap.h:411: void trace(Visitor*);
Should this not be mark?

https://codereview.chromium.org/106423003/diff/40001/Source/heap/Heap.h#newco...
Source/heap/Heap.h:1279: if (Traits::needsMarking)
I think this should be needsTracing

[Mads Ager (chromium), 2013-12-06 11:00:10]

https://codereview.chromium.org/106423003/diff/40001/Source/heap/Heap.h
File Source/heap/Heap.h (right):

https://codereview.chromium.org/106423003/diff/40001/Source/heap/Heap.h#newco...
Source/heap/Heap.h:411: void trace(Visitor*);
On 2013/12/06 10:30:33, Erik Corry wrote:
> Should this not be mark?

Yeah, I probably went a little bit too far with this one. We are tracing the
LargeHeapObject to mark to actual object in there, but that is far-fetched. I'll
rename to mark. Thanks!

https://codereview.chromium.org/106423003/diff/40001/Source/heap/Heap.h#newco...
Source/heap/Heap.h:1279: if (Traits::needsMarking)
On 2013/12/06 10:30:33, Erik Corry wrote:
> I think this should be needsTracing

Yes, will fix.

[Mads Ager (chromium), 2013-12-06 11:00:36]

Committed patchset #4 manually as r163311 (presubmit successful).