Issue 106423002: Remove fourth argument to createNodeIterator/createTreeWalker

Issue 106423002: Remove fourth argument to createNodeIterator/createTreeWalker (Closed)

Created:
7 years ago by philipj_slow

Modified:
7 years ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
blink-reviews, arv+blink, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, watchdog-blink-watchlist_google.com, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Remove fourth argument to createNodeIterator/createTreeWalker http://dom.spec.whatwg.org/#dom-document-createnodeiterator http://dom.spec.whatwg.org/#dom-document-createtreewalker As shown by the test cases, the extra argument is ignored, so it does not need to be in the IDL in order to be compatible with legacy code. BUG=325922 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163271

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+44 lines, -43 lines)			Patch
M	LayoutTests/fast/dom/NodeIterator/NodeIterator-basic.html	View	2 chunks	+27 lines, -13 lines	0 comments	Download
M	LayoutTests/fast/dom/NodeIterator/NodeIterator-basic-expected.txt	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	LayoutTests/fast/dom/TreeWalker/TreeWalker-basic.html	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	LayoutTests/fast/dom/TreeWalker/TreeWalker-basic-expected.txt	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/dom/Document.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/dom/Document.cpp	View	2 chunks	+0 lines, -21 lines	0 comments	Download
M	Source/core/dom/Document.idl	View	1 chunk	+3 lines, -7 lines	0 comments	Download

Total messages: 6 (0 generated)

jochen (gone - plz use gerrit)

can you please upload again? The base files are missing

7 years ago (2013-12-05 11:17:09 UTC) #2

philipj_slow

On 2013/12/05 11:17:09, jochen wrote: > can you please upload again? The base files are ...

7 years ago (2013-12-05 11:51:02 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/106423002/20001

7 years ago (2013-12-05 14:26:11 UTC) #5

Message was sent while issue was closed.

Change committed as 163271