views: Change CardUnmaskPromptViews::FadeOutView opacity to alpha.

views: Change CardUnmaskPromptViews::FadeOutView opacity to alpha.

Store an 0-255 alpha value instead of a 0-1 opacity value on the class
since that is what we will use for painting.

R=pkasting

Committed: https://crrev.com/06cf7258babe8e44b904d36ac9beb9a954e985e4
Cr-Commit-Position: refs/heads/master@{#324220}

[Peter Kasting, 2015-04-07 21:45:30]

pkasting@chromium.org changed reviewers:
+ pkasting@chromium.org

[Peter Kasting, 2015-04-07 21:45:30]

You may want to use uint8_t for this change depending on the discussion in the
other CL (I would).

https://codereview.chromium.org/1064213002/diff/1/chrome/browser/ui/views/aut...
File chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc (right):

https://codereview.chromium.org/1064213002/diff/1/chrome/browser/ui/views/aut...
chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc:483: alpha_ =
gfx::ToRoundedInt(opacity * 255);
My intent was to make this function also take an int and have its callers work
in ints as well.

[danakj, 2015-04-07 21:47:05]

https://codereview.chromium.org/1064213002/diff/1/chrome/browser/ui/views/aut...
File chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc (right):

https://codereview.chromium.org/1064213002/diff/1/chrome/browser/ui/views/aut...
chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc:330:
progress_overlay_->SetOpacity(animation->GetCurrentValue());
The animation value is in the range 0-1. So we'd have to turn these into 0-255
here. It seems a bit nicer to make that conversion inside the SetOpacity
function to me, wdyt? Would you prefer to ToRoundedInt(255*...) here for both
animation values?

[danakj, 2015-04-07 22:01:54]

Changed alpha_ to a uint8_t.

[Peter Kasting, 2015-04-07 22:09:41]

On 2015/04/07 22:01:54, danakj wrote:
> Changed alpha_ to a uint8_t.

OK.  I'd still like to see the change plumbed up to the caller side.

[danakj, 2015-04-07 22:22:32]

Ok PTAL

[Peter Kasting, 2015-04-07 22:29:43]

LGTM with a change

https://codereview.chromium.org/1064213002/diff/60001/chrome/browser/ui/views...
File chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc (right):

https://codereview.chromium.org/1064213002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc:330: uint8_t alpha
= gfx::ToRoundedInt(255 * animation->GetCurrentValue());
Use CurrentValueBetween instead and make the cast explicit:

  uint8_t alpha = static_cast<uint8_t>(animation->CurrentValueBetween(0, 255));

[danakj, 2015-04-07 22:36:43]

https://codereview.chromium.org/1064213002/diff/60001/chrome/browser/ui/views...
File chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc (right):

https://codereview.chromium.org/1064213002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc:330: uint8_t alpha
= gfx::ToRoundedInt(255 * animation->GetCurrentValue());
On 2015/04/07 22:29:42, Peter Kasting wrote:
> Use CurrentValueBetween instead and make the cast explicit:
> 
>   uint8_t alpha = static_cast<uint8_t>(animation->CurrentValueBetween(0,
255));

Done.

[danakj, 2015-04-07 22:36:47]

Patchset #5 (id:80001) has been deleted

[danakj, 2015-04-08 08:06:09]

The CQ bit was checked by danakj@chromium.org

[danakj, 2015-04-08 08:06:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/1064213002/#ps100001
(title: "alpha-view: between")

[commit-bot: I haz the power, 2015-04-08 08:06:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1064213002/100001

[commit-bot: I haz the power, 2015-04-08 12:45:01]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2015-04-08 12:45:58]

Patchset 5 (id:??) landed as
https://crrev.com/06cf7258babe8e44b904d36ac9beb9a954e985e4
Cr-Commit-Position: refs/heads/master@{#324220}