Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Issue 1064183002: content/aura: Use gfx::Canvas::DrawRect instead of unwrapping SkCanvas. (Closed)

Created:
5 years, 8 months ago by danakj
Modified:
5 years, 8 months ago
Reviewers:
sadrul
CC:
chromium-reviews, darin-cc_chromium.org, jam, enne (OOO), oshima, piman, sky
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

content/aura: Use gfx::Canvas::DrawRect instead of unwrapping SkCanvas. There's no need to go through gfx::Canvas to the SkCanvas underneath, use the gfx::Canvas API instead. R=sadrul BUG=466426 Committed: https://crrev.com/5cfc9f5a1f67bfd94e96e77a3b6e7aa7b1c3fcee Cr-Commit-Position: refs/heads/master@{#324255}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M content/browser/web_contents/aura/shadow_layer_delegate.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
danakj
5 years, 8 months ago (2015-04-07 21:21:16 UTC) #1
danakj
Depends on https://codereview.chromium.org/1066183002/
5 years, 8 months ago (2015-04-07 21:21:20 UTC) #2
sadrul
lgtm
5 years, 8 months ago (2015-04-08 15:53:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1064183002/1
5 years, 8 months ago (2015-04-08 16:30:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-08 18:34:10 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 18:36:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5cfc9f5a1f67bfd94e96e77a3b6e7aa7b1c3fcee
Cr-Commit-Position: refs/heads/master@{#324255}

Powered by Google App Engine
This is Rietveld 408576698