Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 1064163002: Add ANGLE platform tracing methods. (Closed)

Created:
5 years, 8 months ago by Jamie Madill
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add ANGLE platform tracing methods. This enables event tracing in ANGLE via the new APIs. This can replace the old methods via SetTraceFunctionPointers. BUG=436191 Committed: https://crrev.com/5eef409e3a90d4e71515338270269a7b13226f50 Cr-Commit-Position: refs/heads/master@{#324232}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -49 lines) Patch
M ui/gl/angle_platform_impl.h View 1 chunk +16 lines, -0 lines 0 comments Download
M ui/gl/angle_platform_impl.cc View 2 chunks +44 lines, -0 lines 0 comments Download
M ui/gl/gl_implementation_win.cc View 2 chunks +0 lines, -49 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Jamie Madill
PTAL, still need to do a bit of manual re-testing.
5 years, 8 months ago (2015-04-07 21:16:46 UTC) #2
Ken Russell (switch to Gerrit)
lgtm
5 years, 8 months ago (2015-04-07 22:01:02 UTC) #3
Jamie Madill
Verified manually that the D3D9 startup trace still works.
5 years, 8 months ago (2015-04-08 16:05:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1064163002/1
5 years, 8 months ago (2015-04-08 16:07:31 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-08 16:33:21 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 16:34:21 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5eef409e3a90d4e71515338270269a7b13226f50
Cr-Commit-Position: refs/heads/master@{#324232}

Powered by Google App Engine
This is Rietveld 408576698