Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 1064153002: Mark operator() as const for VS 2015 compat. (Closed)

Created:
5 years, 8 months ago by brucedawson
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark operator() as const for VS 2015 compat. VS 2015 RC says, when compiling device_monitor_win.cpp: error C3848: expression having type 'const device::`anonymous-namespace' ::CompareGUID' would lose some const-volatile qualifiers in order to call 'bool device::`anonymous-namespace'::CompareGUID::operator ()(const GUID &,const GUID &)' For details see the STL Breaking Changes (VS14 CTP1) section of: http://blogs.msdn.com/b/vcblog/archive/2014/06/06/ c-14-stl-features-fixes-and-breaking-changes-in- visual-studio-14-ctp1.aspx The complaint, apparently, is that operator() is non-const. Whether this is actually invalid is for the language lawyers to decide. Marking it const is more accurate anyway. R=reillyg@chromium.org BUG=440500 Committed: https://crrev.com/708ba318c48d27b840274b004ab4ba532e8b8924 Cr-Commit-Position: refs/heads/master@{#324129}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M device/core/device_monitor_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
brucedawson
5 years, 8 months ago (2015-04-07 20:56:33 UTC) #1
Reilly Grant (use Gerrit)
lgtm
5 years, 8 months ago (2015-04-07 20:59:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1064153002/1
5 years, 8 months ago (2015-04-07 20:59:59 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-07 21:52:16 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 21:56:39 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/708ba318c48d27b840274b004ab4ba532e8b8924
Cr-Commit-Position: refs/heads/master@{#324129}

Powered by Google App Engine
This is Rietveld 408576698