Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issue 1064133002: Disable another debug test under turbo always-opt (Closed)

Created:
5 years, 8 months ago by adamk
Modified:
5 years, 8 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Disable another debug test under turbo always-opt TBR=mstarzinger@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/74ef072148af30e55a263bc9e8c63b2fff8619e2 Cr-Commit-Position: refs/heads/master@{#27642}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M test/mjsunit/mjsunit.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1064133002/1
5 years, 8 months ago (2015-04-07 20:09:52 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-07 20:10:03 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/74ef072148af30e55a263bc9e8c63b2fff8619e2 Cr-Commit-Position: refs/heads/master@{#27642}
5 years, 8 months ago (2015-04-07 20:10:39 UTC) #4
Michael Starzinger
Ack. LGTM! Also thanks a bunch for doing this instead of reverting. It is really ...
5 years, 8 months ago (2015-04-07 22:55:00 UTC) #5
adamk
5 years, 8 months ago (2015-04-07 23:09:18 UTC) #6
Message was sent while issue was closed.
On 2015/04/07 22:55:00, Michael Starzinger wrote:
> Ack. LGTM! Also thanks a bunch for doing this instead of reverting. It is
really
> important for all if V8 (not just TurboFan) that we get this additional test
> coverage. I will investigate the failures.

Any chance the GC Stress flakiness is related at all? That also seemed to pop up
around the same time (though those bots are historically very flaky anyway).

Powered by Google App Engine
This is Rietveld 408576698