Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1330)

Unified Diff: ui/compositor/layer_unittest.cc

Issue 1064103002: ui: Make compositor unittests access the canvas through PaintRecorder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/compositor/paint_context.h » ('j') | ui/compositor/paint_context.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/compositor/layer_unittest.cc
diff --git a/ui/compositor/layer_unittest.cc b/ui/compositor/layer_unittest.cc
index b6039fb17a0237f30386353ac42d296bb28214f3..9622b2f1f342a8f9112bfd8f7acfdc6df9d5028b 100644
--- a/ui/compositor/layer_unittest.cc
+++ b/ui/compositor/layer_unittest.cc
@@ -28,6 +28,7 @@
#include "ui/compositor/layer_animation_sequence.h"
#include "ui/compositor/layer_animator.h"
#include "ui/compositor/paint_context.h"
+#include "ui/compositor/paint_recorder.h"
#include "ui/compositor/test/context_factories_for_test.h"
#include "ui/compositor/test/draw_waiter_for_test.h"
#include "ui/compositor/test/test_compositor_host.h"
@@ -64,7 +65,8 @@ class ColoredLayer : public Layer, public LayerDelegate {
// Overridden from LayerDelegate:
void OnPaintLayer(const ui::PaintContext& context) override {
- context.canvas()->DrawColor(color_);
+ ui::PaintRecorder recorder(context);
+ recorder.canvas()->DrawColor(color_);
}
void OnDelegatedFrameDamage(const gfx::Rect& damage_rect_in_dip) override {}
@@ -229,7 +231,8 @@ class TestLayerDelegate : public LayerDelegate {
// Overridden from LayerDelegate:
void OnPaintLayer(const ui::PaintContext& context) override {
- context.canvas()->DrawColor(colors_[color_index_]);
+ ui::PaintRecorder recorder(context);
+ recorder.canvas()->DrawColor(colors_[color_index_]);
color_index_ = (color_index_ + 1) % static_cast<int>(colors_.size());
}
@@ -272,7 +275,8 @@ class DrawTreeLayerDelegate : public LayerDelegate {
// Overridden from LayerDelegate:
void OnPaintLayer(const ui::PaintContext& context) override {
painted_ = true;
- context.canvas()->DrawColor(SK_ColorWHITE);
+ ui::PaintRecorder recorder(context);
+ recorder.canvas()->DrawColor(SK_ColorWHITE);
}
void OnDelegatedFrameDamage(const gfx::Rect& damage_rect_in_dip) override {}
void OnDeviceScaleFactorChanged(float device_scale_factor) override {}
@@ -1206,20 +1210,17 @@ class SchedulePaintLayerDelegate : public LayerDelegate {
return value;
}
- const gfx::RectF& last_clip_rect() const { return last_clip_rect_; }
+ const gfx::Rect& last_clip_rect() const { return last_clip_rect_; }
private:
// Overridden from LayerDelegate:
void OnPaintLayer(const ui::PaintContext& context) override {
- gfx::Canvas* canvas = context.canvas();
paint_count_++;
if (!schedule_paint_rect_.IsEmpty()) {
layer_->SchedulePaint(schedule_paint_rect_);
schedule_paint_rect_ = gfx::Rect();
}
- SkRect sk_clip_rect;
- if (canvas->sk_canvas()->getClipBounds(&sk_clip_rect))
- last_clip_rect_ = gfx::SkRectToRectF(sk_clip_rect);
+ last_clip_rect_ = context.InvalidationForTesting();
}
void OnDelegatedFrameDamage(const gfx::Rect& damage_rect_in_dip) override {}
@@ -1233,7 +1234,7 @@ class SchedulePaintLayerDelegate : public LayerDelegate {
int paint_count_;
Layer* layer_;
gfx::Rect schedule_paint_rect_;
- gfx::RectF last_clip_rect_;
+ gfx::Rect last_clip_rect_;
DISALLOW_COPY_AND_ASSIGN(SchedulePaintLayerDelegate);
};
« no previous file with comments | « no previous file | ui/compositor/paint_context.h » ('j') | ui/compositor/paint_context.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698