build/toolchain/mac/BUILD.gn - Issue 1064063002: Fix GN mac toolchain error.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/toolchain/mac/BUILD.gn

Issue 1064063002: Fix GN mac toolchain error. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/toolchain/mac/BUILD.gn

diff --git a/build/toolchain/mac/BUILD.gn b/build/toolchain/mac/BUILD.gn

index 18ee8b8cd9bd68d9e0c05e424f88dd75a50a529b..7eb4f2b6929a10e913181c0b1e1664035af285ea 100644

--- a/build/toolchain/mac/BUILD.gn

+++ b/build/toolchain/mac/BUILD.gn

@@ -196,8 +196,7 @@ template("mac_clang_toolchain") {

toolchain_args() {

current_os = invoker.toolchain_os

- # TODO(dpranke): os is here for backwards compatibility.

- os = current_os

+ target_os = current_os

tfarina 2015/04/07 18:03:13 is this correct? should be something else like hos

Dirk Pranke 2015/04/07 18:48:18 No, definitely not. You should never change target

tfarina 2015/04/07 20:06:34 Done.

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »