Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 1064063002: Fix GN mac toolchain error. (Closed)

Created:
5 years, 8 months ago by tfarina
Modified:
5 years, 8 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix GN mac toolchain error. When you run `gn gen out-gn/Debug` on Mac you get the following: ERROR at //build/toolchain/mac/BUILD.gn:200:12: Build argument has no effect. os = current_os ^--------- The variable "os" was set as a build argument but never appeared in a declare_args() block in any buildfile. BUG=None TEST=`gn gen out-gn/Debug` passes without the above error R=dpranke@chromium.org Committed: https://crrev.com/53ec706bbc5debe052dd51e4d93e2de4c2802ab2 Cr-Commit-Position: refs/heads/master@{#324109}

Patch Set 1 #

Total comments: 3

Patch Set 2 : remove it instead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M build/toolchain/mac/BUILD.gn View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
tfarina
https://codereview.chromium.org/1064063002/diff/1/build/toolchain/mac/BUILD.gn File build/toolchain/mac/BUILD.gn (right): https://codereview.chromium.org/1064063002/diff/1/build/toolchain/mac/BUILD.gn#newcode199 build/toolchain/mac/BUILD.gn:199: target_os = current_os is this correct? should be something ...
5 years, 8 months ago (2015-04-07 18:03:13 UTC) #1
Dirk Pranke
https://codereview.chromium.org/1064063002/diff/1/build/toolchain/mac/BUILD.gn File build/toolchain/mac/BUILD.gn (right): https://codereview.chromium.org/1064063002/diff/1/build/toolchain/mac/BUILD.gn#newcode199 build/toolchain/mac/BUILD.gn:199: target_os = current_os On 2015/04/07 18:03:13, tfarina wrote: > ...
5 years, 8 months ago (2015-04-07 18:48:18 UTC) #2
tfarina
https://codereview.chromium.org/1064063002/diff/1/build/toolchain/mac/BUILD.gn File build/toolchain/mac/BUILD.gn (right): https://codereview.chromium.org/1064063002/diff/1/build/toolchain/mac/BUILD.gn#newcode199 build/toolchain/mac/BUILD.gn:199: target_os = current_os On 2015/04/07 18:48:18, Dirk Pranke wrote: ...
5 years, 8 months ago (2015-04-07 20:06:34 UTC) #3
Dirk Pranke
lgtm
5 years, 8 months ago (2015-04-07 20:17:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1064063002/20001
5 years, 8 months ago (2015-04-07 20:33:33 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-07 20:38:22 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 20:39:16 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/53ec706bbc5debe052dd51e4d93e2de4c2802ab2
Cr-Commit-Position: refs/heads/master@{#324109}

Powered by Google App Engine
This is Rietveld 408576698