Make test runner more chatty to avoid it getting killed by buildbot.

Make test runner more chatty to avoid it getting killed by buildbot.

NOTRY=true
NOTREECHECKS=true

Committed: https://crrev.com/a54f22d418cb2e43d813844666f4035ca546685e
Cr-Commit-Position: refs/heads/master@{#27653}

[Michael Achenbach, 2015-04-08 08:37:21]

machenbach@chromium.org changed reviewers:
+ jkummerow@chromium.org, tandrii@chromium.org

[Michael Achenbach, 2015-04-08 08:37:21]

PTAL

[Benedikt Meurer, 2015-04-08 08:54:00]

bmeurer@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Benedikt Meurer, 2015-04-08 08:54:01]

LGTM

[Jakob Kummerow, 2015-04-08 09:00:34]

LGTM with comments.

https://codereview.chromium.org/1064043002/diff/20001/tools/testrunner/local/...
File tools/testrunner/local/pool.py (right):

https://codereview.chromium.org/1064043002/diff/20001/tools/testrunner/local/...
tools/testrunner/local/pool.py:29: class Heartbeat():
I'm not too happy with this kind of polymorphism. I'd use a single class
("MaybeResult"?), that always contains the same set of fields, and has
convenience factory functions to construct "heartbeat" and "actual result"
instances. This would be similar to e.g. MaybeHandles in our C++ code.
I guess it's fine to keep this as is though, if you prefer.

https://codereview.chromium.org/1064043002/diff/20001/tools/testrunner/local/...
tools/testrunner/local/pool.py:89: hearbeat of the runner, i.e. indicating that
the runner is still waiting
nit: "heartbeat"

https://codereview.chromium.org/1064043002/diff/20001/tools/testrunner/local/...
tools/testrunner/local/pool.py:111: # Indicate a heartbeat. The iterater will
continue fetching the
nit: "iterator"

[Michael Achenbach, 2015-04-08 09:30:30]

Done

[Michael Achenbach, 2015-04-08 09:33:33]

The CQ bit was checked by machenbach@chromium.org

[Michael Achenbach, 2015-04-08 09:33:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/1064043002/#ps80001
(title: "...")

[commit-bot: I haz the power, 2015-04-08 09:33:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1064043002/80001

[Michael Achenbach, 2015-04-08 09:53:10]

The CQ bit was unchecked by machenbach@chromium.org

[Michael Achenbach, 2015-04-08 09:53:12]

The CQ bit was checked by machenbach@chromium.org

[Michael Achenbach, 2015-04-08 09:53:24]

The CQ bit was unchecked by machenbach@chromium.org

[commit-bot: I haz the power, 2015-04-08 09:53:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1064043002/80001

[Michael Achenbach, 2015-04-08 09:53:27]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2015-04-08 09:53:41]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-04-08 09:53:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1064043002/80001

[commit-bot: I haz the power, 2015-04-08 09:53:51]

Patchset 5 (id:??) landed as
https://crrev.com/a54f22d418cb2e43d813844666f4035ca546685e
Cr-Commit-Position: refs/heads/master@{#27653}