Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1063983002: Fix regression: allow resetting password and enabling UI input on screenlock (Closed)

Created:
5 years, 8 months ago by Nikita (slow)
Modified:
5 years, 8 months ago
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix regression: allow resetting password and enabling UI input on screenlock BUG=474451 Committed: https://crrev.com/f1c584f915721f8991aaeabfdd0cad7cc1be4891 Cr-Commit-Position: refs/heads/master@{#324029}

Patch Set 1 #

Total comments: 1

Patch Set 2 : remove #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/chromeos/login/ui/webui_login_display.cc View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
Nikita (slow)
5 years, 8 months ago (2015-04-07 09:28:44 UTC) #2
Nikita (slow)
https://codereview.chromium.org/1063983002/diff/1/chrome/browser/chromeos/login/ui/webui_login_display.cc File chrome/browser/chromeos/login/ui/webui_login_display.cc (right): https://codereview.chromium.org/1063983002/diff/1/chrome/browser/chromeos/login/ui/webui_login_display.cc#newcode99 chrome/browser/chromeos/login/ui/webui_login_display.cc:99: !StartupUtils::IsWebviewSigninEnabled()) || ginkage@ I'm not sure that this condition ...
5 years, 8 months ago (2015-04-07 09:36:31 UTC) #3
Nikita (slow)
On 2015/04/07 09:36:31, Nikita Kostylev wrote: > https://codereview.chromium.org/1063983002/diff/1/chrome/browser/chromeos/login/ui/webui_login_display.cc > File chrome/browser/chromeos/login/ui/webui_login_display.cc (right): > > https://codereview.chromium.org/1063983002/diff/1/chrome/browser/chromeos/login/ui/webui_login_display.cc#newcode99 ...
5 years, 8 months ago (2015-04-07 09:50:26 UTC) #4
Dmitry Polukhin
lgtm
5 years, 8 months ago (2015-04-07 09:56:45 UTC) #5
Nikita (slow)
Ok, I've tested on TOT and removed this check completely.
5 years, 8 months ago (2015-04-07 10:03:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1063983002/20001
5 years, 8 months ago (2015-04-07 10:18:51 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-07 10:46:07 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/f1c584f915721f8991aaeabfdd0cad7cc1be4891 Cr-Commit-Position: refs/heads/master@{#324029}
5 years, 8 months ago (2015-04-07 10:47:03 UTC) #11
Nikita (slow)
5 years, 8 months ago (2015-04-07 11:15:55 UTC) #12
Message was sent while issue was closed. 
On 2015/04/07 10:03:21, Nikita Kostylev wrote:
> Ok, I've tested on TOT and removed this check completely.

Per discussion with Ivan this condition was responsible for preventing double
loading in case of whitelist error.
Since I'm changing whitelist error UI, I'll take care of that too.

Powered by Google App Engine
This is Rietveld 408576698