Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1553)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1063953003: Run compiler_rt test suite on FYI bots (Closed)

Created:
5 years, 8 months ago by Derek Schuff
Modified:
5 years, 8 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@print_libgcc
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

Run compiler_rt test suite on FYI bots Runs both the PNaCl bitcode version and nacl-clang. Running the translator version is a bit trickier and not covered yet.

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : bump COMPONENT_REVISIONS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M buildbot/buildbot_pnacl_toolchain_tests.sh View 1 2 chunks +9 lines, -0 lines 0 comments Download
M pnacl/COMPONENT_REVISIONS View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Derek Schuff
5 years, 8 months ago (2015-04-07 21:52:15 UTC) #2
jvoung (off chromium)
lgtm https://codereview.chromium.org/1063953003/diff/20001/buildbot/buildbot_pnacl_toolchain_tests.sh File buildbot/buildbot_pnacl_toolchain_tests.sh (right): https://codereview.chromium.org/1063953003/diff/20001/buildbot/buildbot_pnacl_toolchain_tests.sh#newcode188 buildbot/buildbot_pnacl_toolchain_tests.sh:188: # Run the torture tests. Update comment?
5 years, 8 months ago (2015-04-07 22:07:15 UTC) #3
Derek Schuff
https://codereview.chromium.org/1063953003/diff/20001/buildbot/buildbot_pnacl_toolchain_tests.sh File buildbot/buildbot_pnacl_toolchain_tests.sh (right): https://codereview.chromium.org/1063953003/diff/20001/buildbot/buildbot_pnacl_toolchain_tests.sh#newcode188 buildbot/buildbot_pnacl_toolchain_tests.sh:188: # Run the torture tests. On 2015/04/07 22:07:15, jvoung ...
5 years, 8 months ago (2015-04-07 23:09:57 UTC) #4
Derek Schuff
5 years, 8 months ago (2015-04-07 23:44:17 UTC) #5 
On 2015/04/07 23:09:57, Derek Schuff wrote:
>
https://codereview.chromium.org/1063953003/diff/20001/buildbot/buildbot_pnacl...
> File buildbot/buildbot_pnacl_toolchain_tests.sh (right):
> 
>
https://codereview.chromium.org/1063953003/diff/20001/buildbot/buildbot_pnacl...
> buildbot/buildbot_pnacl_toolchain_tests.sh:188: # Run the torture tests.
> On 2015/04/07 22:07:15, jvoung wrote:
> > Update comment?
> 
> Done.

landed as 6a47074c9845db33c80566313fa987d959931919, but git cl barfed.

Powered by Google App Engine
This is Rietveld 408576698