Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1063873004: DM: add --multiPage option (Closed)

Created:
5 years, 8 months ago by hal.canary
Modified:
5 years, 8 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

DM: add --multiPage option Motivation: I want to switch back to single-page output by default for direct comparison to raster backends in Gold. I can still test the multi-page option via a command-line switch. BUG=skia:3721 Committed: https://skia.googlesource.com/skia/+/7e79818137f2173302d6476a6127525b11684ec2

Patch Set 1 #

Total comments: 2

Patch Set 2 : 2015-04-14 (Tuesday) 16:49:26 EDT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -24 lines) Patch
M dm/DMSrcSink.cpp View 1 2 chunks +42 lines, -24 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
hal.canary
PTAL
5 years, 8 months ago (2015-04-14 20:42:14 UTC) #2
mtklein
https://codereview.chromium.org/1063873004/diff/1/dm/DMSrcSink.cpp File dm/DMSrcSink.cpp (right): https://codereview.chromium.org/1063873004/diff/1/dm/DMSrcSink.cpp#newcode373 dm/DMSrcSink.cpp:373: Let's just DEFINE_bool(multiPage, false, "...") here? Seems like less ...
5 years, 8 months ago (2015-04-14 20:46:27 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1063873004/1
5 years, 8 months ago (2015-04-14 20:46:55 UTC) #5
hal.canary
https://codereview.chromium.org/1063873004/diff/1/dm/DMSrcSink.cpp File dm/DMSrcSink.cpp (right): https://codereview.chromium.org/1063873004/diff/1/dm/DMSrcSink.cpp#newcode373 dm/DMSrcSink.cpp:373: On 2015/04/14 20:46:27, mtklein wrote: > Let's just DEFINE_bool(multiPage, ...
5 years, 8 months ago (2015-04-14 20:50:03 UTC) #6
mtklein
lgtm
5 years, 8 months ago (2015-04-14 20:55:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1063873004/20001
5 years, 8 months ago (2015-04-14 20:56:05 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-14 21:06:23 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/7e79818137f2173302d6476a6127525b11684ec2

Powered by Google App Engine
This is Rietveld 408576698