Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 1063873003: Refactor in HttpStreamFactoryImpl::Job. (Closed)

Created:
5 years, 8 months ago by Bence
Modified:
5 years, 8 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Call GetSpdySessionKey in HttpStreamFactoryImpl::Job::DoCreateStream. * Call GetSpdySessionKey in HttpStreamFactoryImpl::Job::DoCreateStream; * minor refactor in HttpStreamFactoryImpl::Job::DoInitConnection; * change HttpStreamFactoryImpl::Job::GetSpdySessionKey to not use privacy_mode for proxy (DoCreateStream already behaved this way). BUG=474217 Committed: https://crrev.com/9bed1a72f840095556e8ace75af2556e8938f034 Cr-Commit-Position: refs/heads/master@{#325240}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -38 lines) Patch
M net/http/http_stream_factory_impl_job.cc View 1 5 chunks +27 lines, -38 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Bence
Ryan, PTAL. Thanks.
5 years, 8 months ago (2015-04-14 19:29:18 UTC) #2
Ryan Hamilton
LGTM, Can you come up with a title for this CL which is a bit ...
5 years, 8 months ago (2015-04-14 23:24:47 UTC) #3
Bence
Thanks. https://codereview.chromium.org/1063873003/diff/1/net/http/http_stream_factory_impl_job.cc File net/http/http_stream_factory_impl_job.cc (right): https://codereview.chromium.org/1063873003/diff/1/net/http/http_stream_factory_impl_job.cc#newcode278 net/http/http_stream_factory_impl_job.cc:278: PrivacyMode privacy_mode = request_info_.privacy_mode; On 2015/04/14 23:24:47, Ryan ...
5 years, 8 months ago (2015-04-15 13:12:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1063873003/20001
5 years, 8 months ago (2015-04-15 13:12:21 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-15 14:45:31 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 14:46:28 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9bed1a72f840095556e8ace75af2556e8938f034
Cr-Commit-Position: refs/heads/master@{#325240}

Powered by Google App Engine
This is Rietveld 408576698