Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Side by Side Diff: .gn

Issue 1063873002: Add a GN exec_script whitelist. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: more nacl Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # This file is used by the GN meta build system to find the root of the source 1 # This file is used by the GN meta build system to find the root of the source
2 # tree and to set startup options. For documentation on the values set in this 2 # tree and to set startup options. For documentation on the values set in this
3 # file, run "gn help dotfile" at the command line. 3 # file, run "gn help dotfile" at the command line.
4 4
5 # The location of the build configuration file. 5 # The location of the build configuration file.
6 buildconfig = "//build/config/BUILDCONFIG.gn" 6 buildconfig = "//build/config/BUILDCONFIG.gn"
7 7
8 # The secondary source root is a parallel directory tree where 8 # The secondary source root is a parallel directory tree where
9 # GN build files are placed when they can not be placed directly 9 # GN build files are placed when they can not be placed directly
10 # in the source tree, e.g. for third party source trees. 10 # in the source tree, e.g. for third party source trees.
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 "//sync/*", 68 "//sync/*",
69 "//testing/*", 69 "//testing/*",
70 70
71 #"//third_party/*", # May not ever want this. 71 #"//third_party/*", # May not ever want this.
72 "//tools/*", 72 "//tools/*",
73 73
74 #"//ui/*", # Just a few problems. 74 #"//ui/*", # Just a few problems.
75 "//url/*", 75 "//url/*",
76 "//v8/*", 76 "//v8/*",
77 ] 77 ]
78
79 # These are the list of GN files that run exec_script. This whitelist exists
80 # to force additional review for new uses of exec_script, which is strongly
81 # discouraged except for gypi_to_gn calls.
82 exec_script_whitelist = [
83 "//ash/BUILD.gn",
84 "//build/config/android/BUILD.gn",
85 "//build/config/android/config.gni",
86 "//build/config/android/internal_rules.gni",
87 "//build/config/android/rules.gni",
88 "//build/config/compiler/BUILD.gn",
89 "//build/config/gcc/gcc_version.gni",
90 "//build/config/ios/ios_sdk.gni",
91 "//build/config/linux/BUILD.gn",
92 "//build/config/linux/pkg_config.gni",
93 "//build/config/mac/mac_sdk.gni",
94 "//build/config/win/visual_studio_version.gni",
95 "//build/gn_helpers.py",
96 "//build/gypi_to_gn.py",
97 "//build/toolchain/gcc_toolchain.gni",
98 "//build/toolchain/mac/BUILD.gn",
99 "//build/toolchain/win/BUILD.gn",
100 "//chrome/android/BUILD.gn",
101 "//chrome/browser/BUILD.gn",
102 "//chrome/browser/chromeos/BUILD.gn",
103 "//chrome/browser/extensions/BUILD.gn",
104 "//chrome/browser/ui/BUILD.gn",
105 "//chrome/chrome_tests.gni",
106 "//chrome/common/BUILD.gn",
107 "//chrome/common/extensions/api/schemas.gni",
108 "//chrome/renderer/BUILD.gn",
109 "//chrome/test/BUILD.gn",
110 "//chrome/utility/BUILD.gn",
111 "//chromeos/BUILD.gn",
112 "//components/domain_reliability/BUILD.gn",
113 "//components/webui_generator/generator/wug.gni",
114 "//content/browser/browser.gni",
115 "//content/child/child.gni",
116 "//content/common/common.gni",
117 "//content/content.gni",
118 "//content/public/android/BUILD.gn",
119 "//content/renderer/renderer.gni",
120 "//content/test/BUILD.gn",
121 "//extensions/common/api/schemas.gni",
122 "//extensions/extensions.gni",
123 "//extensions/shell/app_shell.gni",
124 "//extensions/shell/common/api/schemas.gni",
125 "//google_apis/BUILD.gn",
126 "//gpu/gles2_conform_support/BUILD.gn",
127 "//jingle/BUILD.gn",
128 "//native_client/build/toolchain/gcc_toolchain.gni",
129 "//native_client/build/toolchain/nacl/BUILD.gn",
130 "//native_client/build/config/android/BUILD.gn",
131 "//native_client/build/config/gcc/gcc_version.gni",
132 "//native_client/build/config/ios/ios_sdk.gni",
133 "//native_client/build/config/linux/BUILD.gn",
134 "//native_client/build/config/linux/pkg_config.gni",
135 "//native_client/build/config/mac/mac_sdk.gni",
136 "//native_client/build/config/win/visual_studio_version.gni",
137 "//native_client/build/toolchain/gcc_toolchain.gni",
138 "//native_client/build/toolchain/mac/BUILD.gn",
139 "//native_client/build/toolchain/nacl/BUILD.gn",
140 "//native_client/build/toolchain/win/BUILD.gn",
141 "//net/BUILD.gn",
142 "//ppapi/ppapi_sources.gni",
143 "//printing/BUILD.gn",
144 "//remoting/host/BUILD.gn",
145 "//remoting/remoting_srcs.gni",
146 "//remoting/remoting_version.gni",
147 "//skia/BUILD.gn",
148 "//third_party/android_platform/BUILD.gn",
149 "//third_party/angle/BUILD.gn",
150 "//third_party/boringssl/BUILD.gn",
151 "//third_party/cld_2/BUILD.gn",
152 "//third_party/cython/rules.gni",
153 "//third_party/google_input_tools/inputview.gni",
154 "//third_party/harfbuzz-ng/BUILD.gn",
155 "//third_party/libaddressinput/BUILD.gn",
156 "//third_party/opus/BUILD.gn",
157 "//third_party/WebKit/Source/bindings/bindings.gni",
158 "//third_party/WebKit/Source/bindings/scripts/scripts.gni",
159 "//third_party/WebKit/Source/config.gni",
160 "//third_party/WebKit/Source/core/core.gni",
161 "//third_party/WebKit/Source/devtools/BUILD.gn",
162 "//third_party/WebKit/Source/modules/modules.gni",
163 "//third_party/WebKit/Source/platform/BUILD.gn",
164 "//third_party/WebKit/Source/platform/platform.gni",
165 "//third_party/WebKit/Source/web/BUILD.gn",
166 "//third_party/WebKit/Source/wtf/BUILD.gn",
167 "//tools/gn/BUILD.gn",
168 "//tools/gn/build_settings.h",
169 "//tools/gn/command_help.cc",
170 "//tools/gn/docs/language.md",
171 "//tools/gn/format_test_data/053.gn",
172 "//tools/gn/format_test_data/053.golden",
173 "//tools/gn/format_test_data/055.gn",
174 "//tools/gn/format_test_data/055.golden",
175 "//tools/gn/function_exec_script.cc",
176 "//tools/gn/gn.gyp",
177 "//tools/gn/input_conversion.cc",
178 "//tools/gn/misc/emacs/gn.el",
179 "//tools/gn/misc/vim/syntax/gn.vim",
180 "//tools/gn/setup.cc",
181 "//ui/views/BUILD.gn",
182 ]
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698