Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 1063863004: [Extensions UI] Add tests for disabling/enabling/uninstalling extensions (Closed)

Created:
5 years, 8 months ago by Devlin
Modified:
5 years, 8 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions UI] Add tests for disabling/enabling/uninstalling extensions Add some tests for disabling/enabling/uninstalling extensions from the chrome://extensions page. Since we don't have any, these will help us determine if we break anything during the transition to observing events from the developerPrivate API. BUG=461039 Committed: https://crrev.com/8363aa5def44e7942b582195e015e05570efae1e Cr-Commit-Position: refs/heads/master@{#324076}

Patch Set 1 : #

Patch Set 2 : Dan's #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -25 lines) Patch
M chrome/browser/resources/extensions/extension_list.js View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_browsertest.h View 2 chunks +9 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_browsertest.cc View 6 chunks +34 lines, -23 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_browsertest.js View 1 1 chunk +102 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Devlin
Per request, tests have been extracted to this CL.
5 years, 8 months ago (2015-04-06 23:51:14 UTC) #3
Dan Beam
first round of comments is here: https://codereview.chromium.org/1049483003/#msg13
5 years, 8 months ago (2015-04-06 23:56:48 UTC) #4
Devlin
On 2015/04/06 23:56:48, Dan Beam wrote: > first round of comments is here: > https://codereview.chromium.org/1049483003/#msg13 ...
5 years, 8 months ago (2015-04-07 15:57:12 UTC) #6
Dan Beam
lgtm
5 years, 8 months ago (2015-04-07 16:52:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1063863004/60001
5 years, 8 months ago (2015-04-07 17:31:57 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years, 8 months ago (2015-04-07 18:30:14 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 18:31:48 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8363aa5def44e7942b582195e015e05570efae1e
Cr-Commit-Position: refs/heads/master@{#324076}

Powered by Google App Engine
This is Rietveld 408576698