OOBE sign in fixes for enterprise_PowerManagement

OOBE sign in fixes for enterprise_PowerManagement

Debugging some tests that were unblocked by codereview.chromium.org/1084793002, I found that waiting for the password field to disappear sometimes fails. We need to wait for the OOBE page to disappear before continuing to the test logic.

BUG=480571
Committed: https://crrev.com/73106a2356a596e8d831019c3de62d0920e4f7c7
Cr-Commit-Position: refs/heads/master@{#326915}

[David Abrahams, 2015-04-23 23:15:50]

resetswitch@chromium.org changed reviewers:
+ achuith@chromium.org

[achuithb, 2015-04-23 23:24:34]

https://codereview.chromium.org/1063853008/diff/20001/tools/telemetry/telemet...
File tools/telemetry/telemetry/core/backends/chrome/oobe.py (left):

https://codereview.chromium.org/1063853008/diff/20001/tools/telemetry/telemet...
tools/telemetry/telemetry/core/backends/chrome/oobe.py:105:
"document.getElementById('%s') == null" % field, 20)
So you're saying that this fails for the password field?

https://codereview.chromium.org/1063853008/diff/20001/tools/telemetry/telemet...
File tools/telemetry/telemetry/core/backends/chrome/oobe.py (right):

https://codereview.chromium.org/1063853008/diff/20001/tools/telemetry/telemet...
tools/telemetry/telemetry/core/backends/chrome/oobe.py:93:
self._NavigateWebViewEmailEntry(username)
Let's just inline _NavigateWebViewEmailEntry and _NavigateWebViewPasswordEntry.
They are only 2 lines each and only called from one place.

[David Abrahams, 2015-04-24 00:58:48]

https://codereview.chromium.org/1063853008/diff/20001/tools/telemetry/telemet...
File tools/telemetry/telemetry/core/backends/chrome/oobe.py (left):

https://codereview.chromium.org/1063853008/diff/20001/tools/telemetry/telemet...
tools/telemetry/telemetry/core/backends/chrome/oobe.py:105:
"document.getElementById('%s') == null" % field, 20)
On 2015/04/23 23:24:34, achuithb wrote:
> So you're saying that this fails for the password field?

Acknowledged.

Yes, the webview frequently closes before getElementById('password')==null,
causing a test failure.

https://codereview.chromium.org/1063853008/diff/20001/tools/telemetry/telemet...
File tools/telemetry/telemetry/core/backends/chrome/oobe.py (right):

https://codereview.chromium.org/1063853008/diff/20001/tools/telemetry/telemet...
tools/telemetry/telemetry/core/backends/chrome/oobe.py:93:
self._NavigateWebViewEmailEntry(username)
On 2015/04/23 23:24:34, achuithb wrote:
> Let's just inline _NavigateWebViewEmailEntry and
_NavigateWebViewPasswordEntry.
> They are only 2 lines each and only called from one place.

Done.

[achuithb, 2015-04-24 20:22:15]

lgtm

[achuithb, 2015-04-24 20:22:22]

The CQ bit was checked by achuith@chromium.org

[commit-bot: I haz the power, 2015-04-24 20:22:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1063853008/40001

[commit-bot: I haz the power, 2015-04-24 22:55:25]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-04-24 22:56:23]

Patchset 3 (id:??) landed as
https://crrev.com/73106a2356a596e8d831019c3de62d0920e4f7c7
Cr-Commit-Position: refs/heads/master@{#326915}