Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: runtime/observatory/tests/service/test_helper.dart

Issue 1063853006: Update hack in test_helper.dart to handle new error message. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 // VMOptions=--compile-all --error_on_bad_type --error_on_bad_override --checked 4 // VMOptions=--compile-all --error_on_bad_type --error_on_bad_override --checked
5 5
6 library test_helper; 6 library test_helper;
7 7
8 import 'dart:async'; 8 import 'dart:async';
9 import 'dart:convert'; 9 import 'dart:convert';
10 import 'dart:io'; 10 import 'dart:io';
11 import 'package:observatory/service_io.dart'; 11 import 'package:observatory/service_io.dart';
12 12
13 bool _isWebSocketDisconnect(e) { 13 bool _isWebSocketDisconnect(e) {
14 if (e is! ServiceException) { 14 if (e is! ServiceException) {
15 return false; 15 return false;
16 } 16 }
17 return (e as ServiceException).message == 'WebSocket disconnected'; 17 return (e as ServiceException).message == 'WebSocket closed';
18 } 18 }
19 19
20 // This invocation should set up the state being tested. 20 // This invocation should set up the state being tested.
21 const String _TESTEE_MODE_FLAG = "--testee-mode"; 21 const String _TESTEE_MODE_FLAG = "--testee-mode";
22 22
23 class _TestLauncher { 23 class _TestLauncher {
24 Process process; 24 Process process;
25 final List<String> args; 25 final List<String> args;
26 bool killedByTester = false; 26 bool killedByTester = false;
27 27
(...skipping 159 matching lines...) Expand 10 before | Expand all | Expand 10 after
187 }, onError: (e, st) { 187 }, onError: (e, st) {
188 process.requestExit(); 188 process.requestExit();
189 if (!_isWebSocketDisconnect(e)) { 189 if (!_isWebSocketDisconnect(e)) {
190 print('Unexpected exception in service tests: $e $st'); 190 print('Unexpected exception in service tests: $e $st');
191 throw e; 191 throw e;
192 } 192 }
193 }); 193 });
194 }); 194 });
195 } 195 }
196 } 196 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698