Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1992)

Unified Diff: android_webview/browser/browser_view_renderer.h

Issue 1063853005: Unify Android Webview and Chrome's fling (Closed) Base URL: https://chromium.googlesource.com/a/chromium/src.git@master
Patch Set: add a todo Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/browser_view_renderer.h
diff --git a/android_webview/browser/browser_view_renderer.h b/android_webview/browser/browser_view_renderer.h
index 477a039cecc344617fb77a5424e38c8310d498e0..dae2d99fcd4de5f61e6fc50fc10d3b9cd43678eb 100644
--- a/android_webview/browser/browser_view_renderer.h
+++ b/android_webview/browser/browser_view_renderer.h
@@ -74,6 +74,7 @@ class BrowserViewRenderer : public content::SynchronousCompositorClient {
void OnSizeChanged(int width, int height);
void OnAttachedToWindow(int width, int height);
void OnDetachedFromWindow();
+ void OnComputeScroll(base::TimeTicks animation_time);
// Sets the scale for logical<->physical pixel conversions.
void SetDipScale(float dip_scale);
@@ -106,7 +107,9 @@ class BrowserViewRenderer : public content::SynchronousCompositorClient {
float page_scale_factor,
float min_page_scale_factor,
float max_page_scale_factor) override;
- bool IsExternalFlingActive() const override;
+ bool IsExternalScrollActive() const override;
+ void SetNeedsAnimateScroll(
+ const AnimationCallback& scroll_animation) override;
void DidOverscroll(gfx::Vector2dF accumulated_overscroll,
gfx::Vector2dF latest_overscroll_delta,
gfx::Vector2dF current_fling_velocity) override;
@@ -144,6 +147,10 @@ class BrowserViewRenderer : public content::SynchronousCompositorClient {
// compositor that are not directly exposed here.
void ForceFakeCompositeSW();
+ // Honor the requested fling animation as contained in
+ // |pending_fling_animation_|.
+ void FlushPendingScrollAnimation(base::TimeTicks animation_time);
+
gfx::Vector2d max_scroll_offset() const;
void UpdateMemoryPolicy();
@@ -179,6 +186,11 @@ class BrowserViewRenderer : public content::SynchronousCompositorClient {
gfx::Size size_;
+ // Used to drive a fling animation as requested by the compositor. This acts
+ // as a single-shot animation; the compositor will continually post an
boliu 2015/05/29 19:42:47 nit: extra space
+ // animation callback as long as they're required.
+ AnimationCallback pending_fling_animation_;
+
// Current scroll offset in CSS pixels.
gfx::Vector2dF scroll_offset_dip_;
« no previous file with comments | « no previous file | android_webview/browser/browser_view_renderer.cc » ('j') | android_webview/browser/browser_view_renderer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698