content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java - Issue 1063853005: Unify Android Webview and Chrome's fling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 1063853005: Unify Android Webview and Chrome's fling (Closed) Base URL: https://chromium.googlesource.com/a/chromium/src.git@master

Patch Set: for review Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/input/layer_scroll_offset_delegate.h ('K') | « content/browser/android/in_process/synchronous_compositor_impl.cc ('k') | content/public/android/javatests/src/org/chromium/content/browser/ContentViewReadbackTest.java » ('j') | content/renderer/input/input_handler_proxy.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

index af50532b6375159ed83ca38273ff1604a33ca353..acb951c50a9165d68c547cb47a2b56be7cb76972 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

@@ -1313,8 +1313,7 @@ public class ContentViewCore

nativeDoubleTap(mNativeContentViewCore, timeMs, x, y);

}

- @VisibleForTesting

- public void flingForTest(long timeMs, int x, int y, int velocityX, int velocityY) {

+ public void fling(long timeMs, int x, int y, int velocityX, int velocityY) {

if (mNativeContentViewCore == 0) return;

nativeFlingCancel(mNativeContentViewCore, timeMs);

nativeScrollBegin(mNativeContentViewCore, timeMs, x, y, velocityX, velocityY);