Use HTML messages to inform GAIA about deviceId.

Use HTML messages to inform GAIA about deviceId.

BUG=470746, 479171
TEST=manual

Committed: https://crrev.com/794248215c501c8722eb042e3b12e93b133335b7
Cr-Commit-Position: refs/heads/master@{#326777}

[Alexander Alekseev, 2015-04-22 14:54:53]

alemate@chromium.org changed reviewers:
+ nkostylev@chromium.org

[Alexander Alekseev, 2015-04-22 14:54:53]

Please review.

[Alexander Alekseev, 2015-04-22 15:30:24]

PTAL.

[Alexander Alekseev, 2015-04-22 15:31:58]

CC: +haon : FYI

[Alexander Alekseev, 2015-04-22 15:32:35]

+haon@ : FYI

[Alexander Alekseev, 2015-04-22 15:33:35]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-22 15:35:09]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1063753004/20001

[commit-bot: I haz the power, 2015-04-22 16:26:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-22 16:26:39]

Dry run: This issue passed the CQ dry run.

[Nikita (slow), 2015-04-22 16:46:52]

https://codereview.chromium.org/1063753004/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc (right):

https://codereview.chromium.org/1063753004/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc:179:
temporary_device_id_(base::GenerateGUID()),
As discussed, let's store this device ID only to avoid GAIA preload state
invalidation.

[Nikita (slow), 2015-04-22 16:51:52]

https://codereview.chromium.org/1063753004/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/screen_gaia_signin.js (right):

https://codereview.chromium.org/1063753004/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/screen_gaia_signin.js:553: * Invoked
when the auth host emits 'attemptLogin' event.
nit: Add information about parameter.

https://codereview.chromium.org/1063753004/diff/1/chrome/browser/resources/ga...
File chrome/browser/resources/gaia_auth_host/authenticator.js (right):

https://codereview.chromium.org/1063753004/diff/1/chrome/browser/resources/ga...
chrome/browser/resources/gaia_auth_host/authenticator.js:460:
this.dispatchEvent(new CustomEvent('attemptLogin', {detail: msg.email}));
As discussed, we should only process 'attemptLogin' in such way when it only
contains email. No need to process further 'attemptLogin' messages (email +
password).

[Alexander Alekseev, 2015-04-22 17:58:07]

https://codereview.chromium.org/1063753004/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/screen_gaia_signin.js (right):

https://codereview.chromium.org/1063753004/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/screen_gaia_signin.js:553: * Invoked
when the auth host emits 'attemptLogin' event.
On 2015/04/22 16:51:52, Nikita Kostylev wrote:
> nit: Add information about parameter.

Done.

https://codereview.chromium.org/1063753004/diff/1/chrome/browser/resources/ga...
File chrome/browser/resources/gaia_auth_host/authenticator.js (right):

https://codereview.chromium.org/1063753004/diff/1/chrome/browser/resources/ga...
chrome/browser/resources/gaia_auth_host/authenticator.js:460:
this.dispatchEvent(new CustomEvent('attemptLogin', {detail: msg.email}));
On 2015/04/22 16:51:52, Nikita Kostylev wrote:
> As discussed, we should only process 'attemptLogin' in such way when it only
> contains email. No need to process further 'attemptLogin' messages (email +
> password).

Done.

https://codereview.chromium.org/1063753004/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc (right):

https://codereview.chromium.org/1063753004/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc:179:
temporary_device_id_(base::GenerateGUID()),
On 2015/04/22 16:46:52, Nikita Kostylev wrote:
> As discussed, let's store this device ID only to avoid GAIA preload state
> invalidation.

Done.

[Nikita (slow), 2015-04-23 12:23:12]

lgtm

https://codereview.chromium.org/1063753004/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc (right):

https://codereview.chromium.org/1063753004/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc:944: if
(context.device_id.empty()) {
nit: drop {}

[Alexander Alekseev, 2015-04-24 12:01:57]

https://codereview.chromium.org/1063753004/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc (right):

https://codereview.chromium.org/1063753004/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc:944: if
(context.device_id.empty()) {
On 2015/04/23 12:23:12, Nikita Kostylev wrote:
> nit: drop {}

Done.

[Alexander Alekseev, 2015-04-24 12:02:13]

The CQ bit was checked by alemate@chromium.org

[Alexander Alekseev, 2015-04-24 12:02:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
nkostylev@chromium.org
Link to the patchset: https://codereview.chromium.org/1063753004/#ps60001
(title: "Update after review.")

[commit-bot: I haz the power, 2015-04-24 12:02:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1063753004/60001

[commit-bot: I haz the power, 2015-04-24 13:01:21]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-04-24 13:02:09]

Patchset 4 (id:??) landed as
https://crrev.com/794248215c501c8722eb042e3b12e93b133335b7
Cr-Commit-Position: refs/heads/master@{#326777}

[Nikita (slow), 2015-04-29 12:42:24]

https://codereview.chromium.org/1063753004/diff/60001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc (right):

https://codereview.chromium.org/1063753004/diff/60001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc:585:
gaia::CanonicalizeEmail(email));
This doesn't work:

[5977:5977:0429/154046:ERROR:gaia_auth_util.cc(28)] NOTREACHED() hit in
CanonicalizeEmailImpl. expecting exactly one @, but got 0 : crosmsk3

You should also call SanitizeEmail which will add default domain (gmail.com)