Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 1063713002: DM: set source options only when non-empty. (Closed)

Created:
5 years, 8 months ago by mtklein_C
Modified:
5 years, 8 months ago
Reviewers:
jcgregorio, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

DM: set source options only when non-empty. BUG=skia: Committed: https://skia.googlesource.com/skia/+/20c1c047e0800385c8729e304a6a511f41fd3cfc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M dm/DMJsonWriter.cpp View 1 chunk +11 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
mtklein
5 years, 8 months ago (2015-04-06 14:07:58 UTC) #2
jcgregorio
lgtm
5 years, 8 months ago (2015-04-06 14:11:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1063713002/1
5 years, 8 months ago (2015-04-06 14:14:41 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-06 14:22:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/20c1c047e0800385c8729e304a6a511f41fd3cfc

Powered by Google App Engine
This is Rietveld 408576698