Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1693)

Unified Diff: Source/devtools/front_end/resources/ServiceWorkersView.js

Issue 1063693002: [WIP] Support opening an inspector window for ServiceWorker running on Android (blink) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebase Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/resources/ServiceWorkersView.js
diff --git a/Source/devtools/front_end/resources/ServiceWorkersView.js b/Source/devtools/front_end/resources/ServiceWorkersView.js
index ffa00f377d40690fd2c467abcc5bb76aeeb8f483..89c741f28d63717d05a75f861022e8f8d393fe37 100644
--- a/Source/devtools/front_end/resources/ServiceWorkersView.js
+++ b/Source/devtools/front_end/resources/ServiceWorkersView.js
@@ -346,7 +346,7 @@ WebInspector.SWRegistrationElement.prototype = {
runningStatusDiv.classList.add("service-workers-version-running-status-inspectable");
var inspectButton = runningStatusDiv.createChild("div", "service-workers-version-inspect");
inspectButton.createTextChild(WebInspector.UIString("inspect"));
- inspectButton.addEventListener("click", this._inspectButtonClicked.bind(this, version.id), false);
+ inspectButton.addEventListener("click", this._inspectButtonClicked.bind(this, version.workerId), false);
}
runningStatusDiv.createChild("div", "service-workers-version-running-status-text").createTextChild(version.runningStatus);
@@ -413,11 +413,12 @@ WebInspector.SWRegistrationElement.prototype = {
},
/**
- * @param {string} versionId
+ * @param {string} workerId
* @param {!Event} event
*/
- _inspectButtonClicked: function(versionId, event)
+ _inspectButtonClicked: function(workerId, event)
{
- this._manager.inspectWorker(versionId);
+ this._manager.detachWorker(workerId);
+ InspectorFrontendHost.openWorkerInspector(workerId);
}
}
« no previous file with comments | « Source/devtools/front_end/host/InspectorFrontendHost.js ('k') | Source/devtools/front_end/sdk/ServiceWorkerManager.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698