Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1063653002: [DevTools] Cleanup after moving input to browser. (Closed)

Created:
5 years, 8 months ago by dgozman
Modified:
5 years, 8 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[DevTools] Cleanup after moving input to browser. BUG=472077 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193629

Patch Set 1 #

Patch Set 2 : More cleanup #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -238 lines) Patch
M Source/core/inspector/InspectorInputAgent.h View 1 chunk +3 lines, -14 lines 0 comments Download
M Source/core/inspector/InspectorInputAgent.cpp View 3 chunks +1 line, -96 lines 0 comments Download
M Source/devtools/protocol.json View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebDevToolsAgentImpl.h View 3 chunks +1 line, -3 lines 0 comments Download
M Source/web/WebDevToolsAgentImpl.cpp View 1 2 5 chunks +4 lines, -40 lines 0 comments Download
M Source/web/WebInputEventConversion.h View 1 2 chunks +0 lines, -7 lines 0 comments Download
M Source/web/WebInputEventConversion.cpp View 1 3 chunks +0 lines, -76 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
dgozman
Take a look please.
5 years, 8 months ago (2015-04-06 10:20:49 UTC) #2
pfeldman
lgtm
5 years, 8 months ago (2015-04-07 13:29:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1063653002/40001
5 years, 8 months ago (2015-04-13 09:49:59 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-13 11:36:41 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193629

Powered by Google App Engine
This is Rietveld 408576698