components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMDriver.java - Issue 1063633004: [GCM] Move GCMListener into chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMDriver.java

Issue 1063633004: [GCM] Move GCMListener into chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix GN and make onMessageReceived public Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/shell/java/AndroidManifest.xml.jinja2 ('K') | « chrome/android/shell/java/AndroidManifest.xml.jinja2 ('k') | components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMListener.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMDriver.java

diff --git a/components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMDriver.java b/components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMDriver.java

index 29c8b4dad80a61b88c2e908e15108c74e4c7c620..1ab551f402bd73e5ec060063e124448a0d89cb93 100644

--- a/components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMDriver.java

+++ b/components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMDriver.java

@@ -117,7 +117,7 @@ public class GCMDriver {

}.execute();

}

- static void onMessageReceived(Context context, final String appId, final Bundle extras) {

+ public static void onMessageReceived(Context context, final String appId, final Bundle extras) {

nyquist 2015/04/09 21:34:16 This feels a bit bad in fact.

Peter Beverloo 2015/04/10 11:52:02 I'm not super concerned about this actually - what

Nicolas Zea 2015/04/10 17:10:29 Sounds good, thanks Peter!

// TODO(johnme): Store message and redeliver later if Chrome is killed before delivery.

ThreadUtils.assertOnUiThread();

launchNativeThen(context, new Runnable() {