chrome/android/BUILD.gn - Issue 1063633004: [GCM] Move GCMListener into chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/BUILD.gn

Issue 1063633004: [GCM] Move GCMListener into chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix GN and make onMessageReceived public Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/android/BUILD.gn

diff --git a/chrome/android/BUILD.gn b/chrome/android/BUILD.gn

index f56bfd05c2f907f59026aad42e6025426cbe6ebd..d73a527e81b82a45ac158d99ee096748ed3f97df 100644

--- a/chrome/android/BUILD.gn

+++ b/chrome/android/BUILD.gn

@@ -96,6 +96,7 @@ android_library("chrome_java") {

"//third_party/android_data_chart:android_data_chart_java",

"//third_party/android_media:android_media_java",

"//third_party/android_protobuf:protobuf_nano_javalib",

+ "//third_party/android_tools:android_gcm_java",

johnme 2015/04/10 13:24:59 Why is this now needed?

Nicolas Zea 2015/04/10 17:10:29 GCMListener is overriding several methods from com

"//third_party/android_tools:android_support_v13_java",

"//third_party/android_tools:android_support_v7_appcompat_java",

"//third_party/android_tools:android_support_v7_mediarouter_java",