Cancel prerender when a site tries to register a protocol handler.

Cancel prerender when a site tries to register a protocol handler.

BUG=134160
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144016

[mmenke, 2012-06-25 19:53:39]

http://codereview.chromium.org/10636034/diff/12004/chrome/browser/prerender/p...
File chrome/browser/prerender/prerender_contents.cc (right):

http://codereview.chromium.org/10636034/diff/12004/chrome/browser/prerender/p...
chrome/browser/prerender/prerender_contents.cc:184: virtual void
JSOutOfMemory(WebContents* tab) OVERRIDE {
We should be consistent about whether we call destroy here, or call a
prerender_contents_ function that does so.  I prefer the former, myself, to keep
stuff out of the header and avoid extra 1-line functions.  If you disagree, can
just go the other way.

[dominich, 2012-06-25 19:59:27]

Don't forget to update the histograms.xml

LGTM

http://codereview.chromium.org/10636034/diff/12004/chrome/browser/prerender/p...
File chrome/browser/prerender/prerender_contents.cc (right):

http://codereview.chromium.org/10636034/diff/12004/chrome/browser/prerender/p...
chrome/browser/prerender/prerender_contents.cc:184: virtual void
JSOutOfMemory(WebContents* tab) OVERRIDE {
On 2012/06/25 19:53:39, Matt Menke wrote:
> We should be consistent about whether we call destroy here, or call a
> prerender_contents_ function that does so.  I prefer the former, myself, to
keep
> stuff out of the header and avoid extra 1-line functions.  If you disagree,
can
> just go the other way.

I like this better.

[mmenke, 2012-06-25 20:01:06]

Thanks for the reminder (and the review), will do.

On 2012/06/25 19:59:27, dominich wrote:
> Don't forget to update the histograms.xml
> 
> LGTM
> 
>
http://codereview.chromium.org/10636034/diff/12004/chrome/browser/prerender/p...
> File chrome/browser/prerender/prerender_contents.cc (right):
> 
>
http://codereview.chromium.org/10636034/diff/12004/chrome/browser/prerender/p...
> chrome/browser/prerender/prerender_contents.cc:184: virtual void
> JSOutOfMemory(WebContents* tab) OVERRIDE {
> On 2012/06/25 19:53:39, Matt Menke wrote:
> > We should be consistent about whether we call destroy here, or call a
> > prerender_contents_ function that does so.  I prefer the former, myself, to
> keep
> > stuff out of the header and avoid extra 1-line functions.  If you disagree,
> can
> > just go the other way.
> 
> I like this better.

[commit-bot: I haz the power, 2012-06-25 20:01:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mmenke@chromium.org/10636034/12004

[commit-bot: I haz the power, 2012-06-25 21:22:45]

Change committed as 144016