Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1063603003: Remove obsolete for_web_contents parameter in FontRenderParamsQuery. (Closed)

Created:
5 years, 8 months ago by stapelberg
Modified:
5 years, 8 months ago
Reviewers:
Daniel Erat, jam, sadrul, msw
CC:
chromium-reviews, sadrul, derat+watch_chromium.org, jam, rickyz+watch_chromium.org, darin-cc_chromium.org, kalyank, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove obsolete for_web_contents parameter in FontRenderParamsQuery. BUG=143619 Committed: https://crrev.com/575097ce8654423b32a15a6cd630398beb0734d3 Cr-Commit-Position: refs/heads/master@{#323920}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Remove obsolete for_web_contents parameter in FontRenderParamsQuery. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -38 lines) Patch
M android_webview/native/aw_settings.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/display_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_preferences_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/libgtk2ui/gtk2_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/sandbox_ipc_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/font_render_params.h View 1 1 chunk +1 line, -6 lines 0 comments Download
M ui/gfx/font_render_params.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ui/gfx/font_render_params_linux.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ui/gfx/font_render_params_linux_unittest.cc View 1 12 chunks +12 lines, -12 lines 0 comments Download
M ui/gfx/platform_font_linux.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M ui/gfx/platform_font_mac.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/platform_font_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gfx/render_text_harfbuzz.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1063603003/1
5 years, 8 months ago (2015-04-05 19:55:45 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 8 months ago (2015-04-05 19:55:47 UTC) #4
stapelberg
Removing this now-unused flag as requested in https://codereview.chromium.org/1020263004/
5 years, 8 months ago (2015-04-05 20:00:25 UTC) #6
Daniel Erat
lgtm with nits https://codereview.chromium.org/1063603003/diff/1/ui/gfx/font_render_params.h File ui/gfx/font_render_params.h (right): https://codereview.chromium.org/1063603003/diff/1/ui/gfx/font_render_params.h#newcode70 ui/gfx/font_render_params.h:70: explicit FontRenderParamsQuery(); nit: remove 'explicit' https://codereview.chromium.org/1063603003/diff/1/ui/gfx/font_render_params_linux_unittest.cc ...
5 years, 8 months ago (2015-04-06 12:23:30 UTC) #8
Daniel Erat
oh, and please add a BUG= line to the change description with the ID of ...
5 years, 8 months ago (2015-04-06 12:24:26 UTC) #9
stapelberg
https://codereview.chromium.org/1063603003/diff/1/ui/gfx/font_render_params.h File ui/gfx/font_render_params.h (right): https://codereview.chromium.org/1063603003/diff/1/ui/gfx/font_render_params.h#newcode70 ui/gfx/font_render_params.h:70: explicit FontRenderParamsQuery(); On 2015/04/06 12:23:29, Daniel Erat wrote: > ...
5 years, 8 months ago (2015-04-06 13:14:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1063603003/20001
5 years, 8 months ago (2015-04-06 13:15:04 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/54276)
5 years, 8 months ago (2015-04-06 13:24:14 UTC) #15
jam
lgtm
5 years, 8 months ago (2015-04-06 16:00:42 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1063603003/20001
5 years, 8 months ago (2015-04-06 18:03:21 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-06 18:31:55 UTC) #19
commit-bot: I haz the power
5 years, 8 months ago (2015-04-06 18:36:51 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/575097ce8654423b32a15a6cd630398beb0734d3
Cr-Commit-Position: refs/heads/master@{#323920}

Powered by Google App Engine
This is Rietveld 408576698