Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1063603002: Mark ui_base_unittests target to be used on Swarming. (Closed)

Created:
5 years, 8 months ago by tfarina
Modified:
5 years, 6 months ago
Reviewers:
Nico, M-A Ruel
CC:
chromium-reviews, Nico
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark ui_base_unittests target to be used on Swarming. Patch generated with the following command line: $ ./testing/buildbot/manage.py --convert ui_base_unittests BUG=98637 TEST=trybots? R=maruel@chromium.org Committed: https://crrev.com/79e2c2139c83ccc50de4a73288eac94ab13b94f0 Cr-Commit-Position: refs/heads/master@{#333991}

Patch Set 1 #

Total comments: 2

Patch Set 2 : m-a #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -0 lines) Patch
M testing/buildbot/chromium.chromiumos.json View 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 1 13 chunks +39 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 1 chunk +3 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.memory.json View 4 chunks +12 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.memory.fyi.json View 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.webkit.json View 2 chunks +6 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.win.json View 5 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (2 generated)
tfarina
Marc-Antoine, can this be done blindly like I did? I mean, there were some ui_base_unittests ...
5 years, 8 months ago (2015-04-05 19:09:31 UTC) #1
tfarina
Marc-Antoine, friendly ping?
5 years, 8 months ago (2015-04-08 19:24:10 UTC) #2
M-A Ruel
Nico, what other builders I should blacklist in manage.py? https://codereview.chromium.org/1063603002/diff/1/testing/buildbot/chromium.fyi.json File testing/buildbot/chromium.fyi.json (right): https://codereview.chromium.org/1063603002/diff/1/testing/buildbot/chromium.fyi.json#newcode66 testing/buildbot/chromium.fyi.json:66: ...
5 years, 8 months ago (2015-04-09 19:10:31 UTC) #3
Nico
I'm only aware of the two clang/win asan bots (shared and static)
5 years, 8 months ago (2015-04-09 19:15:27 UTC) #5
tfarina
https://codereview.chromium.org/1063603002/diff/1/testing/buildbot/chromium.fyi.json File testing/buildbot/chromium.fyi.json (right): https://codereview.chromium.org/1063603002/diff/1/testing/buildbot/chromium.fyi.json#newcode66 testing/buildbot/chromium.fyi.json:66: "can_use_on_swarming_builders": true On 2015/04/09 19:10:31, M-A Ruel wrote: > ...
5 years, 8 months ago (2015-04-09 19:34:22 UTC) #6
tfarina
Marc-Antoine, ping again??
5 years, 8 months ago (2015-04-10 22:14:55 UTC) #7
M-A Ruel
On 2015/04/10 22:14:55, tfarina wrote: > Marc-Antoine, ping again?? I didn't forget, don't worry. I ...
5 years, 8 months ago (2015-04-11 02:15:40 UTC) #8
tfarina
Marc-Antoine, should I close/abandon this?
5 years, 6 months ago (2015-06-11 15:37:03 UTC) #9
M-A Ruel
Now that isolate is fast again, lgtm.
5 years, 6 months ago (2015-06-11 17:10:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1063603002/20001
5 years, 6 months ago (2015-06-11 17:11:31 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-11 18:13:39 UTC) #13
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/79e2c2139c83ccc50de4a73288eac94ab13b94f0 Cr-Commit-Position: refs/heads/master@{#333991}
5 years, 6 months ago (2015-06-11 18:15:50 UTC) #14
hans
On 2015/06/11 18:15:50, commit-bot: I haz the power wrote: > Patchset 2 (id:??) landed as ...
5 years, 6 months ago (2015-06-11 21:57:24 UTC) #15
M-A Ruel
On 2015/06/11 21:57:24, hans wrote: > On 2015/06/11 18:15:50, commit-bot: I haz the power wrote: ...
5 years, 6 months ago (2015-06-11 22:01:34 UTC) #16
Nico
On Thu, Jun 11, 2015 at 3:01 PM, <maruel@chromium.org> wrote: > On 2015/06/11 21:57:24, hans ...
5 years, 6 months ago (2015-06-11 22:02:22 UTC) #17
M-A Ruel
On 2015/06/11 22:02:22, Nico wrote: > On Thu, Jun 11, 2015 at 3:01 PM, <mailto:maruel@chromium.org> ...
5 years, 6 months ago (2015-06-11 22:03:42 UTC) #18
Nico
5 years, 6 months ago (2015-06-11 22:07:37 UTC) #19
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1179083002/ by thakis@chromium.org.

The reason for reverting is: Turns "isolate tests" red on some bots, reverting
while maruel investigates:
http://build.chromium.org/p/chromium.fyi/builders/CrWinClang%28dbg%29/builds/....

Powered by Google App Engine
This is Rietveld 408576698