Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1023)

Issue 10636006: Use glFinish() before EGL context switch for ARM (Closed)

Created:
8 years, 6 months ago by sheu
Modified:
8 years, 6 months ago
CC:
chromium-reviews, dhollowa+watch_chromium.org, anush, Pawel Osciak, piman
Base URL:
https://git.chromium.org/git/chromium/src@master
Visibility:
Public.

Description

Use glFinish() before EGL context switch for ARM Temp workaround for issues on Mali. Apparently we don't care about this affecting Kaen. BUG=None TEST=local build, run Change-Id: I914503cd40d5b587cf6c5b60fa19ad41fd0e709b Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=143568

Patch Set 1 #

Total comments: 1

Patch Set 2 : Comment fix, also commit message #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M ui/gl/gl_context_egl.cc View 1 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
piman
LGTM+nit https://chromiumcodereview.appspot.com/10636006/diff/1/ui/gl/gl_context_egl.cc File ui/gl/gl_context_egl.cc (right): https://chromiumcodereview.appspot.com/10636006/diff/1/ui/gl/gl_context_egl.cc#newcode82 ui/gl/gl_context_egl.cc:82: #if defined(OS_CHROMEOS) && defined(ARCH_CPU_ARMEL) Could we add a ...
8 years, 6 months ago (2012-06-22 00:26:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sheu@chromium.org/10636006/4001
8 years, 6 months ago (2012-06-22 00:35:29 UTC) #2
commit-bot: I haz the power
Presubmit check for 10636006-4001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 6 months ago (2012-06-22 00:35:31 UTC) #3
Ken Russell (switch to Gerrit)
Ugh. LGTM
8 years, 6 months ago (2012-06-22 01:01:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sheu@chromium.org/10636006/4001
8 years, 6 months ago (2012-06-22 01:02:52 UTC) #5
commit-bot: I haz the power
Try job failure for 10636006-4001 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 6 months ago (2012-06-22 01:58:19 UTC) #6
Ken Russell (switch to Gerrit)
FYI: the ContentSettingBubbleControllerTest.Init browser test failure on Mac is a known issue and apparently the ...
8 years, 6 months ago (2012-06-22 02:37:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sheu@chromium.org/10636006/4001
8 years, 6 months ago (2012-06-22 08:32:41 UTC) #8
sheu
Unfortunately, I'm not Chromium committer. :-( Re-CQ-ing.
8 years, 6 months ago (2012-06-22 08:39:41 UTC) #9
commit-bot: I haz the power
8 years, 6 months ago (2012-06-22 10:00:47 UTC) #10
Change committed as 143568

Powered by Google App Engine
This is Rietveld 408576698