LayoutTests/http/tests/navigation/same-document-scroll-position-restore-pushstate.html - Issue 1063573002: history.pushState() should take care of scrolling state

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/navigation/same-document-scroll-position-restore-pushstate.html

Issue 1063573002: history.pushState() should take care of scrolling state (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <body>

	3 <script src="../../../resources/js-test.js"></script>

	4 <div style="height: 1100px">scroll down...</div>

	5 <button id="a">Push State</button>

	6 <div id="log"></div>

	7 <script>

	8 if (window.testRunner) {

	9 testRunner.dumpAsText();

	10 testRunner.waitUntilDone();

	11 }

	12

	13 window.onload = function() {

	14 window.scrollBy(0, 1000);

	15 history.pushState({}, '', "#a");

	16 history.pushState({}, '', "#a");

	17 scrollOffsetY = window.scrollY;

	18 history.back();

	19 setTimeout(function() {

	20 document.getElementById('log').innerHTML = 'scrollY should be ' + scroll OffsetY + ': ' + (window.scrollY==scrollOffsetY ? "PASS" : "FAIL");
	vivekg 2015/04/10 09:00:52 Use shouldBe version instead of using getElementBy Use shouldBe version instead of using getElementById(...). Please refer to [1] [1] https://docs.google.com/document/d/1Yl4SnTLBWmY1O99_BTtQvuoffP8YM9HZx2YPkEsad... Abhijeet Kandalkar Slow 2015/04/10 18:22:17 Done. Show quoted text On 2015/04/10 09:00:52, vivekg_ wrote: > Use shouldBe version instead of using getElementById(...). Please refer to [1] > > [1] > https://docs.google.com/document/d/1Yl4SnTLBWmY1O99_BTtQvuoffP8YM9HZx2YPkEsad... Done.
	21 testRunner.notifyDone();

	22 }, 100);
	Nate Chapin 2015/04/10 17:32:31 100ms is way too long. Ideally this should be call 100ms is way too long. Ideally this should be called with 0ms. Abhijeet Kandalkar Slow 2015/04/10 18:22:17 Done. Show quoted text On 2015/04/10 17:32:31, Nate Chapin wrote: > 100ms is way too long. Ideally this should be called with 0ms. Done.
	23 };

	24 </script>

	25 </body>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/http/tests/navigation/same-document-scroll-position-restore-pushstate-expected.txt » ('j') | no next file with comments »