LayoutTests/http/tests/navigation/same-document-scroll-position-restore-pushstate.html - Issue 1063573002: history.pushState() should take care of scrolling state

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/navigation/same-document-scroll-position-restore-pushstate.html

Issue 1063573002: history.pushState() should take care of scrolling state (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <body>

	3 <script src="../../../resources/js-test.js"></script>

	4 <div style="height: 1100px">scroll down...</div>

	5 <button id="a">Push State</button>

	6 <button id="b">Back</button>
	Nate Chapin 2015/04/07 18:17:09 Nit: I don't think these buttons are needed any mo Nit: I don't think these buttons are needed any more. Abhijeet Kandalkar Slow 2015/04/10 06:49:22 Done. Show quoted text On 2015/04/07 18:17:09, Nate Chapin wrote: > Nit: I don't think these buttons are needed any more. Done.
	7 <div id="log"></div>

	8 <script>

	9 if (window.testRunner)

	10 testRunner.dumpAsText();

	11

	12 window.onload = function() {

	13 window.scrollBy(0, 1000);

	14 history.pushState({}, '', window.location.href.split("#")[0] + "#a");
	Nate Chapin 2015/04/07 18:17:09 Nit: You shouldn't need to parse the url, setting Nit: You shouldn't need to parse the url, setting the url to "#a" should resolve to the same thing. Abhijeet Kandalkar Slow 2015/04/10 06:49:22 Done. Show quoted text On 2015/04/07 18:17:09, Nate Chapin wrote: > Nit: You shouldn't need to parse the url, setting the url to "#a" should resolve > to the same thing. Done.
	15 history.pushState({}, '', window.location.href.split("#")[0] + "#a");

	16 scrollOffsetY = window.scrollY;

	17 history.back();

	18 document.getElementById('log').innerHTML = 'scrollY should be ' + scrollOffs etY + ': ' + (window.scrollY==scrollOffsetY ? "PASS" : "FAIL");
	Nate Chapin 2015/04/07 18:17:09 Does this fail without your fix? I would expect th Does this fail without your fix? I would expect the history.back() to scroll asynchronously. Abhijeet Kandalkar Slow 2015/04/10 06:49:22 On windows sometime it fails while manual testing. Show quoted text On 2015/04/07 18:17:09, Nate Chapin wrote: > Does this fail without your fix? I would expect the history.back() to scroll > asynchronously. On windows sometime it fails while manual testing. Asynchronous implementation is added.
	19 };

	20 </script>

	21 </body>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/http/tests/navigation/same-document-scroll-position-restore-pushstate-expected.txt » ('j') | no next file with comments »