Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1063533002: Initial implementation of stashed message ports, layout tests (Closed)

Created:
5 years, 8 months ago by Marijn Kruisselbrink
Modified:
5 years, 7 months ago
Reviewers:
scheib
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, dglazkov+blink, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@stashed-ports
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Initial implementation of stashed message ports, layout tests This is part of a series of patches to implement an initial version of a mechanism for a MessagePort to outlive a service worker as described in https://github.com/mkruisselbrink/navigator-connect/blob/gh-pages/docs/api-idea.md#persisted-messageports [1/3] https://codereview.chromium.org/1008533005/, blink side implementation [2/3] https://codereview.chromium.org/1110103003/, content side implementation [3/3] this patch, layout tests BUG=426458, 483108 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195643

Patch Set 1 : #

Patch Set 2 : #

Total comments: 8

Patch Set 3 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -0 lines) Patch
A LayoutTests/http/tests/serviceworker/chromium/resources/stashed-ports-echo-worker.js View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/serviceworker/chromium/stashed-ports-after-terminate.html View 1 2 1 chunk +62 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/serviceworker/resources/stashed-ports-basics.js View 1 2 1 chunk +57 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/serviceworker/stashed-ports.html View 1 2 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
scheib
https://codereview.chromium.org/1063533002/diff/80001/LayoutTests/http/tests/serviceworker/chromium/resources/stashed-port-worker.js File LayoutTests/http/tests/serviceworker/chromium/resources/stashed-port-worker.js (right): https://codereview.chromium.org/1063533002/diff/80001/LayoutTests/http/tests/serviceworker/chromium/resources/stashed-port-worker.js#newcode1 LayoutTests/http/tests/serviceworker/chromium/resources/stashed-port-worker.js:1: It would help to have more unique / descriptive ...
5 years, 7 months ago (2015-05-06 22:36:18 UTC) #5
Marijn Kruisselbrink
https://codereview.chromium.org/1063533002/diff/80001/LayoutTests/http/tests/serviceworker/chromium/resources/stashed-port-worker.js File LayoutTests/http/tests/serviceworker/chromium/resources/stashed-port-worker.js (right): https://codereview.chromium.org/1063533002/diff/80001/LayoutTests/http/tests/serviceworker/chromium/resources/stashed-port-worker.js#newcode1 LayoutTests/http/tests/serviceworker/chromium/resources/stashed-port-worker.js:1: On 2015/05/06 22:36:18, scheib wrote: > It would help ...
5 years, 7 months ago (2015-05-13 02:46:03 UTC) #6
scheib
LGTM Though, why have one test script inline in HTML and other external in .js?
5 years, 7 months ago (2015-05-13 04:03:07 UTC) #7
Marijn Kruisselbrink
On 2015/05/13 04:03:07, scheib wrote: > LGTM > > Though, why have one test script ...
5 years, 7 months ago (2015-05-13 04:13:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1063533002/100001
5 years, 7 months ago (2015-05-20 21:49:29 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 23:32:15 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195643

Powered by Google App Engine
This is Rietveld 408576698