https://codereview.chromium.org/1063533002/diff/80001/LayoutTests/http/tests/serviceworker/chromium/resources/stashed-port-worker.js File LayoutTests/http/tests/serviceworker/chromium/resources/stashed-port-worker.js (right): https://codereview.chromium.org/1063533002/diff/80001/LayoutTests/http/tests/serviceworker/chromium/resources/stashed-port-worker.js#newcode1 LayoutTests/http/tests/serviceworker/chromium/resources/stashed-port-worker.js:1: It would help to have more unique / descriptive ...
5 years, 7 months ago
(2015-05-06 22:36:18 UTC)
#5
https://codereview.chromium.org/1063533002/diff/80001/LayoutTests/http/tests/serviceworker/chromium/resources/stashed-port-worker.js File LayoutTests/http/tests/serviceworker/chromium/resources/stashed-port-worker.js (right): https://codereview.chromium.org/1063533002/diff/80001/LayoutTests/http/tests/serviceworker/chromium/resources/stashed-port-worker.js#newcode1 LayoutTests/http/tests/serviceworker/chromium/resources/stashed-port-worker.js:1: On 2015/05/06 22:36:18, scheib wrote: > It would help ...
5 years, 7 months ago
(2015-05-13 02:46:03 UTC)
#6
LGTM Though, why have one test script inline in HTML and other external in .js?
5 years, 7 months ago
(2015-05-13 04:03:07 UTC)
#7
LGTM
Though, why have one test script inline in HTML and other external in .js?
Marijn Kruisselbrink
On 2015/05/13 04:03:07, scheib wrote: > LGTM > > Though, why have one test script ...
5 years, 7 months ago
(2015-05-13 04:13:12 UTC)
#8
On 2015/05/13 04:03:07, scheib wrote:
> LGTM
>
> Though, why have one test script inline in HTML and other external in .js?
One test just tests functionality from within a serviceworker, so the HTML file
doesn't need to do anything besides installing/launching a service worker (which
is all done by service_worker_test), the other test tests behavior that includes
killing the service worker, so there the logic that is running outside the
service worker (in the html file) is more complicated.
Marijn Kruisselbrink
The CQ bit was checked by mek@chromium.org
5 years, 7 months ago
(2015-05-20 21:49:06 UTC)
#9
Issue 1063533002: Initial implementation of stashed message ports, layout tests
(Closed)
Created 5 years, 8 months ago by Marijn Kruisselbrink
Modified 5 years, 7 months ago
Reviewers: scheib
Base URL: https://chromium.googlesource.com/chromium/blink.git@stashed-ports
Comments: 8