Source/core/timing/MemoryInfo.cpp - Issue 106353005: Expose performance.memory in workers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/timing/MemoryInfo.cpp

Issue 106353005: Expose performance.memory in workers (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@Perf-Memory-SharedWorker

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/http/tests/w3c/webperf/submission/Google/HighResolutionTime/worker-shared-basic.html ('K') | « Source/core/timing/MemoryInfo.h ('k') | Source/core/timing/Performance.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/timing/MemoryInfo.cpp

diff --git a/Source/core/timing/MemoryInfo.cpp b/Source/core/timing/MemoryInfo.cpp

index 2abe63ab6f5f39fff6ca9d32721ad106fb2f9cb3..cb60428e3a8a3f2c21dd37a06229da17b10867e5 100644

--- a/Source/core/timing/MemoryInfo.cpp

+++ b/Source/core/timing/MemoryInfo.cpp

@@ -31,6 +31,7 @@

#include "config.h"

#include "core/timing/MemoryInfo.h"

+#include "RuntimeEnabledFeatures.h"

#include <limits>

#include "core/frame/Frame.h"

#include "core/frame/Settings.h"

@@ -132,14 +133,11 @@ size_t quantizeMemorySize(size_t size)

return bucketSizeList[numberOfBuckets - 1];

}

-MemoryInfo::MemoryInfo(Frame* frame)

+MemoryInfo::MemoryInfo()

{

ScriptWrappable::init(this);

- if (!frame || !frame->settings())

- return;

- if (frame->settings()->memoryInfoEnabled()) {

+ if (RuntimeEnabledFeatures::preciseMemoryInfoEnabled()) {

ScriptGCEvent::getHeapSize(m_info);

} else {

DEFINE_STATIC_LOCAL(HeapSizeCache, heapSizeCache, ());