Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 106353002: Nuke Profiler.setRecordingProfile protocol message (Closed)

Created:
7 years ago by yurys
Modified:
7 years ago
Reviewers:
alph, aandrey, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Nuke Profiler.setRecordingProfile protocol message This is send only in response to start/stop commands sent on the front-end so it doesn't make sense to repeat the same to the front-end. BUG=324769 R=alph@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163243

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -29 lines) Patch
M Source/core/inspector/InspectorProfilerAgent.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorProfilerAgent.cpp View 2 chunks +0 lines, -8 lines 0 comments Download
M Source/devtools/front_end/CPUProfileView.js View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/devtools/front_end/CanvasProfileView.js View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/devtools/protocol.json View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
yurys
7 years ago (2013-12-05 09:16:50 UTC) #1
yurys
7 years ago (2013-12-05 09:17:04 UTC) #2
alph
lgtm
7 years ago (2013-12-05 09:21:41 UTC) #3
yurys
7 years ago (2013-12-05 09:23:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r163243 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698