Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1063493002: cc: Remove all traces of synchronous GPU rasterization (Closed)

Created:
5 years, 8 months ago by hendrikw
Modified:
5 years, 8 months ago
Reviewers:
vmpstr, vmiura, piman
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, creis+watch_chromium.org, dzhioev+watch_chromium.org, jam, darin-cc_chromium.org, oshima+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Remove all traces of synchronous GPU rasterization Removed threaded gpu raster flag, and syncronous gpu raster tests and all code required for syncronous gpu rasterization. Removed the empty software rasterizer class, and base and moved ownership of the gpu rasterizer into the GpuTileTaskWorkerPool, since it is still a nice separation of functionality BUG=457860 Committed: https://crrev.com/59d4494849b405682265ed5d3f5164573b9a939b Cr-Commit-Position: refs/heads/master@{#323860}

Patch Set 1 #

Patch Set 2 : more deleted code #

Total comments: 2

Patch Set 3 : nit fix #

Patch Set 4 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -643 lines) Patch
M cc/BUILD.gn View 1 2 3 2 chunks +0 lines, -3 lines 0 comments Download
M cc/cc.gyp View 2 chunks +0 lines, -3 lines 0 comments Download
M cc/resources/gpu_rasterizer.h View 1 3 chunks +4 lines, -33 lines 0 comments Download
M cc/resources/gpu_rasterizer.cc View 1 3 chunks +3 lines, -123 lines 0 comments Download
M cc/resources/gpu_tile_task_worker_pool.h View 4 chunks +11 lines, -3 lines 0 comments Download
M cc/resources/gpu_tile_task_worker_pool.cc View 1 3 chunks +17 lines, -7 lines 0 comments Download
D cc/resources/rasterizer.h View 1 chunk +0 lines, -47 lines 0 comments Download
M cc/resources/resource_provider.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M cc/resources/resource_provider.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
D cc/resources/software_rasterizer.h View 1 chunk +0 lines, -38 lines 0 comments Download
D cc/resources/software_rasterizer.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M cc/resources/tile_manager.h View 1 2 7 chunks +1 line, -10 lines 0 comments Download
M cc/resources/tile_manager.cc View 5 chunks +22 lines, -117 lines 0 comments Download
M cc/resources/tile_manager_unittest.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M cc/resources/tile_task_worker_pool_perftest.cc View 2 chunks +1 line, -4 lines 0 comments Download
M cc/resources/tile_task_worker_pool_unittest.cc View 2 chunks +1 line, -4 lines 0 comments Download
M cc/test/fake_tile_manager.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M cc/test/layer_tree_pixel_resource_test.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/test/layer_tree_pixel_resource_test.cc View 3 chunks +2 lines, -24 lines 0 comments Download
M cc/test/layer_tree_test.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M cc/test/layer_tree_test.cc View 1 2 3 2 chunks +0 lines, -9 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 1 2 3 4 chunks +0 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 2 3 5 chunks +6 lines, -20 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 2 3 2 chunks +3 lines, -69 lines 0 comments Download
M cc/trees/layer_tree_settings.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_settings.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 3 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/gpu/compositor_util.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/gpu/compositor_util.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M content/renderer/gpu/compositor_dependencies.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/render_thread_impl.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M content/test/fake_compositor_dependencies.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/fake_compositor_dependencies.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
hendrikw
PTAL, thanks! https://codereview.chromium.org/1063493002/diff/20001/cc/resources/gpu_tile_task_worker_pool.cc File cc/resources/gpu_tile_task_worker_pool.cc (right): https://codereview.chromium.org/1063493002/diff/20001/cc/resources/gpu_tile_task_worker_pool.cc#newcode212 cc/resources/gpu_tile_task_worker_pool.cc:212: new RasterBufferImpl(rasterizer_.get(), resource)); This was my only ...
5 years, 8 months ago (2015-04-03 22:00:10 UTC) #2
hendrikw
added piman for flag changes (content\)
5 years, 8 months ago (2015-04-03 22:02:46 UTC) #4
piman
lgtm
5 years, 8 months ago (2015-04-03 22:21:16 UTC) #5
vmiura
lgtm % nit. Thanks! https://codereview.chromium.org/1063493002/diff/20001/cc/resources/tile_manager.h File cc/resources/tile_manager.h (left): https://codereview.chromium.org/1063493002/diff/20001/cc/resources/tile_manager.h#oldcode99 cc/resources/tile_manager.h:99: // rasterizer.h nit: Should keep ...
5 years, 8 months ago (2015-04-03 22:22:42 UTC) #6
hendrikw
On 2015/04/03 22:22:42, vmiura wrote: > lgtm % nit. Thanks! > > https://codereview.chromium.org/1063493002/diff/20001/cc/resources/tile_manager.h > File ...
5 years, 8 months ago (2015-04-03 22:27:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1063493002/40001
5 years, 8 months ago (2015-04-03 22:44:33 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/11920) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 8 months ago (2015-04-03 22:51:11 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1063493002/60001
5 years, 8 months ago (2015-04-03 23:18:24 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 8 months ago (2015-04-04 00:44:46 UTC) #16
commit-bot: I haz the power
5 years, 8 months ago (2015-04-04 00:45:37 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/59d4494849b405682265ed5d3f5164573b9a939b
Cr-Commit-Position: refs/heads/master@{#323860}

Powered by Google App Engine
This is Rietveld 408576698