Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1063453002: Fill list style background with same color with that of list background. (Closed)

Created:
5 years, 8 months ago by changseok
Modified:
5 years, 8 months ago
CC:
blink-reviews, dshwang, slimming-paint-reviews_chromium.org, blink-reviews-paint_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fill list style background with same color with that of list background. LayoutListMarker does not have a node so its selectionBackgroundColor alway returns the default theme color for selection. We can make it more natural by filling the same color with that of LayoutListItem into it. BUG=467092 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193335

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Append NeedsReabaseline for linux #

Messages

Total messages: 18 (9 generated)
changseok
PTAL
5 years, 8 months ago (2015-04-03 18:01:26 UTC) #2
changseok
+thakis, +timloh, +esprehn
5 years, 8 months ago (2015-04-06 07:17:17 UTC) #4
eae
Change looks good, would be nice to test it without haivng to use a pixel ...
5 years, 8 months ago (2015-04-07 14:47:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1063453002/1
5 years, 8 months ago (2015-04-07 16:08:57 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/41048) mac_blink_rel on tryserver.blink (JOB_FAILED, ...
5 years, 8 months ago (2015-04-07 16:13:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1063453002/20001
5 years, 8 months ago (2015-04-07 16:22:47 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/56231)
5 years, 8 months ago (2015-04-07 20:06:11 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1063453002/40001
5 years, 8 months ago (2015-04-08 05:22:05 UTC) #17
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 08:03:01 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193335

Powered by Google App Engine
This is Rietveld 408576698